Bug 36904

Summary: Clean up chromium WebNotificationPresenter interface after notification changes
Product: WebKit Reporter: Rafael Weinstein <rafaelw>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Rafael Weinstein
Reported 2010-03-31 15:30:07 PDT
Now that https://bugs.webkit.org/show_bug.cgi?id=36625 and http://codereview.chromium.org/1383001 have landed. Go back and clean up old interface calls.
Attachments
Patch (4.49 KB, patch)
2010-03-31 15:34 PDT, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Patch (4.49 KB, patch)
2010-04-02 11:05 PDT, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Patch (5.45 KB, patch)
2010-04-02 11:17 PDT, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Patch (5.90 KB, patch)
2010-04-02 11:34 PDT, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Patch (5.88 KB, patch)
2010-04-02 11:43 PDT, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Rafael Weinstein
Comment 1 2010-03-31 15:34:44 PDT
Created attachment 52216 [details] Patch
WebKit Review Bot
Comment 2 2010-03-31 15:39:20 PDT
Attachment 52216 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1625110
Adam Barth
Comment 3 2010-03-31 17:29:24 PDT
Comment on attachment 52216 [details] Patch Ok, but please make sure you don't break the chromium build. :)
Rafael Weinstein
Comment 4 2010-04-02 11:05:37 PDT
Created attachment 52425 [details] Patch
WebKit Review Bot
Comment 5 2010-04-02 11:13:49 PDT
Attachment 52425 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1625177
Rafael Weinstein
Comment 6 2010-04-02 11:17:40 PDT
Created attachment 52427 [details] Patch
WebKit Review Bot
Comment 7 2010-04-02 11:29:07 PDT
Attachment 52427 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1574167
Rafael Weinstein
Comment 8 2010-04-02 11:34:56 PDT
Created attachment 52428 [details] Patch
David Levin
Comment 9 2010-04-02 11:37:49 PDT
Comment on attachment 52428 [details] Patch > diff --git a/WebKit/chromium/public/WebNotificationPresenter.h b/WebKit/chromium/public/WebNotificationPresenter.h > + virtual Permission checkPermission(const WebURL& url) = 0; The parameter name "url" adds no information so it shouldn't be present. > + virtual void requestPermission(const WebSecurityOrigin& origin, WebNotificationPermissionCallback* callback) = 0; "origin" and "callback" param names should be removed.
Rafael Weinstein
Comment 10 2010-04-02 11:43:19 PDT
Created attachment 52430 [details] Patch
Adam Barth
Comment 11 2010-04-02 12:49:52 PDT
Comment on attachment 52430 [details] Patch Awesome! Thanks.
WebKit Commit Bot
Comment 12 2010-04-02 15:14:04 PDT
Comment on attachment 52430 [details] Patch Clearing flags on attachment: 52430 Committed r57026: <http://trac.webkit.org/changeset/57026>
WebKit Commit Bot
Comment 13 2010-04-02 15:14:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.