Bug 36892

Summary:

[V8] SerializedScriptValue must be deserialized only once and in the right context

Product:

WebKit

Reporter:

Vitaly Repeshko <vitalyr>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch v1	levin: review+, levin: commit-queue-
patch v1.1	none

Description Vitaly Repeshko 2010-03-31 11:03:01 PDT

[V8] SerializedScriptValue must be deserialized only once and in the right context

Comment 1 Vitaly Repeshko 2010-03-31 11:13:51 PDT

Created attachment 52190 [details]
patch v1

Comment 2 David Levin 2010-03-31 11:35:00 PDT

Comment on attachment 52190 [details]
patch v1


> diff --git a/WebCore/bindings/scripts/CodeGeneratorV8.pm b/WebCore/bindings/scripts/CodeGeneratorV8.pm
> +        if ($serializedAttribute->type =~ /^readonly/) {
> +            $attrAttr .= "|v8::ReadOnly";

Ideally add spaces around | (so the code will match the general WK style).

Comment 3 Vitaly Repeshko 2010-03-31 13:17:40 PDT

Created attachment 52205 [details]
patch v1.1

Comment 4 WebKit Commit Bot 2010-03-31 17:10:02 PDT

Comment on attachment 52205 [details]
patch v1.1

Clearing flags on attachment: 52205

Committed r56877: <http://trac.webkit.org/changeset/56877>

Comment 5 WebKit Commit Bot 2010-03-31 17:10:06 PDT

All reviewed patches have been landed.  Closing bug.