Bug 36889 – Misc IndexedDatabase cleanup

• Component: New Bugs
• Status: RESOLVED FIXED

[Jeremy Orlow]

Misc IndexedDatabase cleanup

[Jeremy Orlow]

Created attachment 52181 [details]
Patch

[WebKit Review Bot]

Attachment 52181 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/IndexedDatabaseProxy.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nate Chapin]

Comment on attachment 52181 [details]
Patch

One question (plus the style violation the script caught). I'm r+ing and assuming Darin will override if he sees something I missed in the WebKit/chromium changes.

> --- a/WebKit/chromium/public/WebIndexedDatabase.h
> +++ b/WebKit/chromium/public/WebIndexedDatabase.h
> @@ -36,6 +36,7 @@ namespace WebKit {
>  
>  class WebIDBDatabase;
>  class WebString;
> +class WebFrame;

Do we care about ordering of these?

[Jeremy Orlow]

(In reply to comment #3)
> (From update of attachment 52181 [details])
> One question (plus the style violation the script caught). I'm r+ing and
> assuming Darin will override if he sees something I missed in the
> WebKit/chromium changes.
> 
> > --- a/WebKit/chromium/public/WebIndexedDatabase.h
> > +++ b/WebKit/chromium/public/WebIndexedDatabase.h
> > @@ -36,6 +36,7 @@ namespace WebKit {
> >  
> >  class WebIDBDatabase;
> >  class WebString;
> > +class WebFrame;
> 
> Do we care about ordering of these?

We do.  This is an artifact of me changing it from WebView to WebFrame at some point.  Will fix before landing.

[Jeremy Orlow]

Committed r56907: <http://trac.webkit.org/changeset/56907>