Bug 36887

Summary:

[chromium] including WebKit.gyp:webkit should automatically add Skia and NPAPI include paths

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

WebKit API

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
v1 patch	levin: review+

Darin Fisher (:fishd, Google)

Reported 2010-03-31 08:52:18 PDT

[chromium] including WebKit.gyp:webkit should automatically add Skia and NPAPI include paths This is what WebCore.gyp does, and since I'm working to remove direct usage of WebCore.gyp in the Chromium repository, it would be good to do the same for WebKit.gyp. That way consumers of the WebKit API do not all have to manually include Skia and NPAPI settings.

Attachments
v1 patch (1.33 KB, patch) 2010-03-31 08:54 PDT, Darin Fisher (:fishd, Google)	levin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Fisher (:fishd, Google)

Comment 1 2010-03-31 08:54:37 PDT

Created attachment 52175 [details] v1 patch

Darin Fisher (:fishd, Google)

Comment 2 2010-03-31 11:01:12 PDT

Landed as http://trac.webkit.org/changeset/56853

Adam Barth

Comment 3 2010-03-31 12:18:18 PDT

http://trac.webkit.org/changeset/56853 appears to have broken Leopard Intel Debug (Tests)

Darin Fisher (:fishd, Google)

Comment 4 2010-03-31 12:20:04 PDT

(In reply to comment #3) > http://trac.webkit.org/changeset/56853 appears to have broken Leopard Intel > Debug (Tests) That must be unrelated since this was purely a GYP change.

Note You need to log in before you can comment on or make changes to this bug.