Bug 36886

Summary:

test-webkitpy: Have the logtesting tearDown() method check that the array of log messages is empty

Product:

WebKit

Reporter:

Chris Jerdonek <cjerdonek>

Component:

Tools / Tests

Assignee:

Chris Jerdonek <cjerdonek>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cjerdonek, hamaji

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	hamaji: review+, cjerdonek: commit-queue-

Description Chris Jerdonek 2010-03-31 08:19:09 PDT

If we make the LogTesting class's tearDown() method assert that the array of log messages is empty, we'll get more mileage out of our unit tests that test log messages -- and with less code.

Comment 1 Chris Jerdonek 2010-03-31 08:56:45 PDT

Created attachment 52176 [details]
Proposed patch

Comment 2 Chris Jerdonek 2010-03-31 21:38:14 PDT

Comment on attachment 52176 [details]
Proposed patch

cq- to commit manually

Comment 3 Chris Jerdonek 2010-03-31 21:52:37 PDT

Committed:

http://trac.webkit.org/changeset/56894