Bug 36885

Summary: Web Inspector: [Chromium] inspector/audits-panel-functional.html crashes test_shell
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
[PATCH] Suggested solution
pfeldman: review-
[PATCH] Comments addressed
[PATCH] CRASH expectation removed none

Description Alexander Pavlov (apavlov) 2010-03-31 07:52:29 PDT
Chromium test shell crashes on inspector/audits-panel-functional.html (which works fine during pure WebKit test runs).
Comment 1 Alexander Pavlov (apavlov) 2010-03-31 08:00:53 PDT
Created attachment 52167 [details]
[PATCH] Suggested solution
Comment 2 Pavel Feldman 2010-03-31 08:15:30 PDT
Comment on attachment 52167 [details]
[PATCH] Suggested solution

> +    setTimeout(function() {evaluateInWebInspector("frontend_runAudits", callback)}, 0);
>  }

This is a hack.

> +    testController.waitUntilDone();

Every wait should have notify.

To fix your problem, do not call layoutTestController's notifyDone upon first return from the front-end.
Comment 3 Alexander Pavlov (apavlov) 2010-03-31 08:20:51 PDT
Created attachment 52171 [details]
[PATCH] Comments addressed
Comment 4 Alexander Pavlov (apavlov) 2010-03-31 08:29:26 PDT
Created attachment 52173 [details]
[PATCH] CRASH expectation removed
Comment 5 WebKit Commit Bot 2010-03-31 09:01:43 PDT
Comment on attachment 52173 [details]
[PATCH] CRASH expectation removed

Clearing flags on attachment: 52173

Committed r56843: <http://trac.webkit.org/changeset/56843>
Comment 6 WebKit Commit Bot 2010-03-31 09:01:48 PDT
All reviewed patches have been landed.  Closing bug.