Summary: | Notifications should not resolve an empty icon parameter as a relative URL | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Gregg <johnnyg> | ||||||
Component: | WebCore Misc. | Assignee: | John Gregg <johnnyg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
John Gregg
2010-03-30 16:17:25 PDT
Also, this was a recent regression. Created attachment 52099 [details]
Patch
Comment on attachment 52099 [details] Patch > Index: WebCore/ChangeLog > + > + No new tests, code is disabled in WebKit. This looks like something that has to be covered by a test. Especially if this is a recent regression, as you say in the bug. The ENABLE_NOTIFICATIONS is enabled in Chromium, so perhaps there is a way to have a test running at least in chromium port? Removing r? for now, feel free to flip back if there is a test or if it is plain impossible to have one. Created attachment 52468 [details]
Patch
Okay, I'm adding a test for this. All the notifications tests are disabled on all platforms pending patches to add the necessary hooks in DumpRenderTree/test_shell, so I'll add this one disabled as well. I have the testing hooks mostly done and can push that through soon, but since this is a regression it would be nice if we could land it with the placeholder test for now. Comment on attachment 52468 [details] Patch Rejecting patch 52468 from commit-queue. johnnyg@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 52468 [details] Patch Clearing flags on attachment: 52468 Committed r57103: <http://trac.webkit.org/changeset/57103> All reviewed patches have been landed. Closing bug. |