Bug 36860

Summary: Updating Chromium media baselines and expectations
Product: WebKit Reporter: Andrew Scherkus <scherkus>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
2010-03-30 Andrew Scherkus <scherkus@chromium.org>
none
2010-03-31 Andrew Scherkus <scherkus@chromium.org>
none
2010-03-31 Andrew Scherkus <scherkus@chromium.org> dimich: review+

Andrew Scherkus
Reported 2010-03-30 16:09:13 PDT
With r56481 landed Chromium can now pass those layout tests.
Attachments
2010-03-30 Andrew Scherkus <scherkus@chromium.org> (5.59 KB, patch)
2010-03-30 16:12 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
2010-03-31 Andrew Scherkus <scherkus@chromium.org> (47.09 KB, patch)
2010-03-31 12:10 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
2010-03-31 Andrew Scherkus <scherkus@chromium.org> (45.56 KB, patch)
2010-03-31 15:14 PDT, Andrew Scherkus 		dimich: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrew Scherkus
Comment 1 2010-03-30 16:12:11 PDT
Created attachment 52094 [details] 2010-03-30 Andrew Scherkus <scherkus@chromium.org>
Andrew Scherkus
Comment 2 2010-03-30 17:18:28 PDT
Comment on attachment 52094 [details] 2010-03-30 Andrew Scherkus <scherkus@chromium.org> This isn't ready to review just yet.
Andrew Scherkus
Comment 3 2010-03-31 12:10:34 PDT
Created attachment 52193 [details] 2010-03-31 Andrew Scherkus <scherkus@chromium.org>
Dmitry Titov
Comment 4 2010-03-31 12:47:03 PDT
media/audio-constructor-src.html seems to have the same baseline here for win and mac, does it actually need a platform-specific baseline? Same question for media/video-source-add-src.html. If the test does not run on Linux, we might disable it in test_expectations for Linux and have one shared result.
Dmitry Titov
Comment 5 2010-03-31 14:31:54 PDT
Comment on attachment 52193 [details] 2010-03-31 Andrew Scherkus <scherkus@chromium.org> Per offline discussion, Andrew is going to update the patch. removing the r? flag to temporarily move the patch out of the queue.
Andrew Scherkus
Comment 6 2010-03-31 15:14:06 PDT
Created attachment 52215 [details] 2010-03-31 Andrew Scherkus <scherkus@chromium.org>
Dmitry Titov
Comment 7 2010-03-31 15:19:13 PDT
Comment on attachment 52215 [details] 2010-03-31 Andrew Scherkus <scherkus@chromium.org> r=me
Andrew Scherkus
Comment 8 2010-03-31 15:54:39 PDT
Committed as http://trac.webkit.org/changeset/56873
Eric Seidel (no email)
Comment 9 2010-03-31 17:17:08 PDT
Looks like fast/workers/worker-terminate.html, http/tests/misc/image-blocked-src-change.html have been failing since this change on the Gtk 32 bit Debug builder: http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Debug
Note You need to log in before you can comment on or make changes to this bug.