Bug 36837

Summary:

LayoutTests/fast/canvas/zero-size-fill-rect.html succeed on Qt, should remove it from Skipped

Product:

WebKit

Reporter:

qi <qi.2.zhang>

Component:

New Bugs

Assignee:

qi <qi.2.zhang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, cshu, laszlo.gombos

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Enable zero-size-fill-rect.html	laszlo.gombos: review+, commit-queue: commit-queue-
repatch	none

Reported 2010-03-30 10:49:54 PDT

LayoutTests/fast/canvas/zero-size-fill-rect.html succeed on Qt, should create expect files and remove it from Skipped

Attachments
Enable zero-size-fill-rect.html (12.68 KB, patch) 2010-03-30 12:42 PDT, qi	laszlo.gombos: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
repatch (12.68 KB, patch) 2010-03-31 07:16 PDT, qi	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Comment 1 2010-03-30 12:42:22 PDT

Created attachment 52070 [details] Enable zero-size-fill-rect.html Remove zero-size-fill-rect.html from Skipped, and create expected files.

Laszlo Gombos

Comment 2 2010-03-30 16:15:24 PDT

Comment on attachment 52070 [details] Enable zero-size-fill-rect.html lgtm, r+. Thanks.

WebKit Commit Bot

Comment 3 2010-03-31 02:26:14 PDT

Comment on attachment 52070 [details] Enable zero-size-fill-rect.html Rejecting patch 52070 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Laszlo Gombos', '--force']" exit_code: 1 Last 500 characters of output: at 1 with fuzz 3. patching file LayoutTests/platform/qt/Skipped Hunk #1 FAILED at 2569. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej patching file LayoutTests/platform/qt/fast/canvas/zero-size-fill-rect-expected.checksum patching file LayoutTests/platform/qt/fast/canvas/zero-size-fill-rect-expected.txt error: pathspec 'LayoutTests/platform/qt/fast/canvas/zero-size-fill-rect-expected.png' did not match any file(s) known to git. Did you forget to 'git add'? Full output: http://webkit-commit-queue.appspot.com/results/1585100

Comment 4 2010-03-31 07:16:16 PDT

Created attachment 52158 [details] repatch Update workspace and repatch.

Laszlo Gombos

Comment 5 2010-03-31 11:25:41 PDT

Comment on attachment 52158 [details] repatch r+, let's try again.

WebKit Commit Bot

Comment 6 2010-03-31 13:38:29 PDT

Comment on attachment 52158 [details] repatch Clearing flags on attachment: 52158 Committed r56865: <http://trac.webkit.org/changeset/56865>

WebKit Commit Bot

Comment 7 2010-03-31 13:38:34 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.