Bug 36837 - LayoutTests/fast/canvas/zero-size-fill-rect.html succeed on Qt, should remove it from Skipped
Summary: LayoutTests/fast/canvas/zero-size-fill-rect.html succeed on Qt, should remove...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: qi
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-03-30 10:49 PDT by qi
Modified: 2010-03-31 13:38 PDT (History)
3 users (show)

See Also:


Attachments
Enable zero-size-fill-rect.html (12.68 KB, patch)
2010-03-30 12:42 PDT, qi
laszlo.gombos: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
repatch (12.68 KB, patch)
2010-03-31 07:16 PDT, qi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description qi 2010-03-30 10:49:54 PDT
LayoutTests/fast/canvas/zero-size-fill-rect.html succeed on Qt, should create expect files and remove it from Skipped
Comment 1 qi 2010-03-30 12:42:22 PDT
Created attachment 52070 [details]
Enable zero-size-fill-rect.html

Remove zero-size-fill-rect.html from Skipped, and create expected files.
Comment 2 Laszlo Gombos 2010-03-30 16:15:24 PDT
Comment on attachment 52070 [details]
Enable zero-size-fill-rect.html

lgtm, r+. Thanks.
Comment 3 WebKit Commit Bot 2010-03-31 02:26:14 PDT
Comment on attachment 52070 [details]
Enable zero-size-fill-rect.html

Rejecting patch 52070 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Laszlo Gombos', '--force']" exit_code: 1
Last 500 characters of output:
at 1 with fuzz 3.
patching file LayoutTests/platform/qt/Skipped
Hunk #1 FAILED at 2569.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej
patching file LayoutTests/platform/qt/fast/canvas/zero-size-fill-rect-expected.checksum
patching file LayoutTests/platform/qt/fast/canvas/zero-size-fill-rect-expected.txt
error: pathspec 'LayoutTests/platform/qt/fast/canvas/zero-size-fill-rect-expected.png' did not match any file(s) known to git.
Did you forget to 'git add'?

Full output: http://webkit-commit-queue.appspot.com/results/1585100
Comment 4 qi 2010-03-31 07:16:16 PDT
Created attachment 52158 [details]
repatch

Update workspace and repatch.
Comment 5 Laszlo Gombos 2010-03-31 11:25:41 PDT
Comment on attachment 52158 [details]
repatch

r+, let's try again.
Comment 6 WebKit Commit Bot 2010-03-31 13:38:29 PDT
Comment on attachment 52158 [details]
repatch

Clearing flags on attachment: 52158

Committed r56865: <http://trac.webkit.org/changeset/56865>
Comment 7 WebKit Commit Bot 2010-03-31 13:38:34 PDT
All reviewed patches have been landed.  Closing bug.