Bug 36829 – [Qt] Send rotation directions when orientation change in Maemo5

• Component: WebKit Qt
• Status: RESOLVED DUPLICATE

[Diego Gonzalez]

Expose API for WebCore::Frame::sendOrientationChangeEvent)
and (WebCore::Frame::orientation).

It is useful for mobile devices when the application wants
to inform Qt WebKit that the device orientation have been
changed and it will also invoke the onorientation event it
can be captured via JavaScript.

[Diego Gonzalez]

(In reply to comment #0)
> Expose API for WebCore::Frame::sendOrientationChangeEvent)
> and (WebCore::Frame::orientation).
>

These methods have been implemented in bug #29508

[Diego Gonzalez]

Created attachment 52077 [details]
Proposed patch

[Simon Hausmann]

It doesn't feel right to me to add an API to QWebPage and bother third-party developers with it. Any change we can make this simply work out of the box?

If necessary using some platform specific code, unless there's already a signal somewhere in Qt (QApplication? QDesktopWidget?)

[Kenneth Rohde Christiansen]

(In reply to comment #3)
> It doesn't feel right to me to add an API to QWebPage and bother third-party
> developers with it. Any change we can make this simply work out of the box?
> 
> If necessary using some platform specific code, unless there's already a signal
> somewhere in Qt (QApplication? QDesktopWidget?)

I gave the same comments on irc. Jesus tells me that there are Maemo specific events but they will only work in PR1.2

[Diego Gonzalez]

(In reply to comment #4)
> (In reply to comment #3)
> > It doesn't feel right to me to add an API to QWebPage and bother third-party
> > developers with it. Any change we can make this simply work out of the box?
> > 
> > If necessary using some platform specific code, unless there's already a signal
> > somewhere in Qt (QApplication? QDesktopWidget?)
> 
> I gave the same comments on irc. Jesus tells me that there are Maemo specific
> events but they will only work in PR1.2

Actually the maemo5 support for orientation will only work in PR1.2 is using setAttribute(Qt::WA_Maemo5AutoOrientation, true); it will provide a maemo application change the device orientation when the it is rotated from portrait to landscape and vice e versa.

Unfortunately, AFAIK the application does not send any event calling the orientation have been changed, of course it could be checked at resize but it could not be the best way. A possible way to get the directions when the device is rotated in maemo5 is getting this information from the accelerometer (Ariya gave me some examples). The other possible way could be using the lib qt mobility which seems has a API for it.

[Diego Gonzalez]

Created attachment 53140 [details]
html test case using onorientationchange event to show the device rotation directions (0, 90, -90 and 180 degrees)

[Diego Gonzalez]

Created attachment 53141 [details]
Send rotation events

An example how the rotation direction could be gotten using the orientation information from accelerometer

[Kenneth Rohde Christiansen]

You want comments on this patch?

[Diego Gonzalez]

(In reply to comment #8)
> You want comments on this patch?

Actually it is just an example how could we get orientation info from the accelerometer and send the rotation direction to webkit. The intention is show some possible ways to do this feature, so we can manage the best way to send these events.

[Diego Gonzalez]

*** This bug has been marked as a duplicate of bug 50685 ***