Bug 36817

Summary:

Web Inspector [v8]: provide v8 binding for InspectorFrontendHost

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	pfeldman: review+
patch that I'm going to land	none

Yury Semikhatsky

Reported 2010-03-30 05:37:22 PDT

WebKit/chromium/src/WebDevToolsFrontendImpl.cpp provides Chromium-specific implementation for InspectorFrontendHost(look at WebDevToolsFrontendImpl constructor). Most of the code can be generated and the rest should reside in bindings layer.

Attachments
patch (42.53 KB, patch) 2010-04-02 02:03 PDT, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
patch that I'm going to land (42.52 KB, patch) 2010-04-02 05:54 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2010-04-02 02:03:37 PDT

Created attachment 52406 [details] patch

Pavel Feldman

Comment 2 2010-04-02 02:35:12 PDT

Comment on attachment 52406 [details] patch Could you merge WebDevToolsFrontendImpl and InspectorFrontendClientImpl? I realize there is a life time clash, but I think we should fix this! > + > + Implement InspectorFrontendHost::showContextMenu for v8. Use Web Inspector prefix. > > +#include "V8MouseEvent.h" > #include "V8Binding.h" Mind alphabetic order.

Yury Semikhatsky

Comment 3 2010-04-02 02:52:42 PDT

(In reply to comment #2) > (From update of attachment 52406 [details]) > Could you merge WebDevToolsFrontendImpl and InspectorFrontendClientImpl? I > realize there is a life time clash, but I think we should fix this! > Filed bug on this: https://bugs.webkit.org/show_bug.cgi?id=37021 > > > + > > + Implement InspectorFrontendHost::showContextMenu for v8. > > Use Web Inspector prefix. > Done. > > > > +#include "V8MouseEvent.h" > > #include "V8Binding.h" > > Mind alphabetic order. Done.

Yury Semikhatsky

Comment 4 2010-04-02 05:54:15 PDT

Created attachment 52409 [details] patch that I'm going to land

Yury Semikhatsky

Comment 5 2010-04-02 05:56:13 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... C WebCore/inspector/InspectorFrontendClientLocal.h => WebKit/chromium/src/InspectorFrontendClientImpl.h M WebCore/ChangeLog M WebCore/WebCore.Inspector.exp M WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp M WebCore/inspector/InspectorFrontendClient.h M WebCore/inspector/InspectorFrontendClientLocal.cpp M WebCore/inspector/InspectorFrontendClientLocal.h M WebCore/inspector/InspectorFrontendHost.cpp M WebCore/inspector/InspectorFrontendHost.h M WebKit/chromium/ChangeLog M WebKit/chromium/WebKit.gyp A WebKit/chromium/src/InspectorFrontendClientImpl.cpp M WebKit/chromium/src/WebDevToolsFrontendImpl.cpp M WebKit/chromium/src/WebDevToolsFrontendImpl.h M WebKit/chromium/src/js/DebuggerAgent.js M WebKit/chromium/src/js/DevTools.js Committed r56999

Note You need to log in before you can comment on or make changes to this bug.