Bug 36804

Summary: NULL pointer crash if XSLT @import fails
Product: WebKit Reporter: Chris Evans <scarybeasts>
Component: XMLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Fix NULL ptr deref
none
Fix style-bot issue.
ap: review+, commit-queue: commit-queue-
Fix missing Reviewed by NOBODY line. none

Chris Evans
Reported 2010-03-29 21:14:36 PDT
This came in as a Chromium security bug, but on analysis appears to be harmless fixed-offset NULL pointer error: http://code.google.com/p/chromium/issues/detail?id=39433 Nevertheless, we are seeing evidence of some real sites being impacted as a stability bug, e.g. www.fotka.pl, so I decided to just fix it. (Likely, there is a crash every time a network or server error gets in the way of an @import load). Patch forthcoming.
Attachments
Fix NULL ptr deref (4.18 KB, patch)
2010-03-29 21:28 PDT, Chris Evans 		no flags
DetailsFormatted DiffDiff
Fix style-bot issue. (4.18 KB, patch)
2010-03-29 21:47 PDT, Chris Evans 		ap: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Fix missing Reviewed by NOBODY line. (4.23 KB, patch)
2010-04-01 14:41 PDT, Chris Evans 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Evans
Comment 1 2010-03-29 21:28:40 PDT
Created attachment 51999 [details] Fix NULL ptr deref
WebKit Review Bot
Comment 2 2010-03-29 21:29:45 PDT
Attachment 51999 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/xml/XSLStyleSheetLibxslt.cpp:158: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Evans
Comment 3 2010-03-29 21:47:39 PDT
Created attachment 52000 [details] Fix style-bot issue.
Alexey Proskuryakov
Comment 4 2010-03-30 13:13:23 PDT
Comment on attachment 52000 [details] Fix style-bot issue. r=me, looks great.
WebKit Commit Bot
Comment 5 2010-03-31 01:16:04 PDT
Comment on attachment 52000 [details] Fix style-bot issue. Rejecting patch 52000 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--build-style=both', '--quiet', '52000', '--no-update']" exit_code: 1 Logging in as eseidel@chromium.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=52000&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=36804&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 52000 from bug 36804. ERROR: LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Eric Seidel (no email)
Comment 6 2010-03-31 01:26:55 PDT
You removed the Reviewed By line from your LayoutTEsts changelog. That caused the failure.
Chris Evans
Comment 7 2010-04-01 14:41:16 PDT
Created attachment 52337 [details] Fix missing Reviewed by NOBODY line.
Chris Evans
Comment 8 2010-04-01 14:42:56 PDT
Oops. Eric / Adam, could you toss it back on the commit queue?
Adam Barth
Comment 9 2010-04-01 14:49:22 PDT
Comment on attachment 52337 [details] Fix missing Reviewed by NOBODY line. Forwarding ap's r+.
WebKit Commit Bot
Comment 10 2010-04-01 17:44:10 PDT
Comment on attachment 52337 [details] Fix missing Reviewed by NOBODY line. Clearing flags on attachment: 52337 Committed r56956: <http://trac.webkit.org/changeset/56956>
WebKit Commit Bot
Comment 11 2010-04-01 17:44:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.