| Summary: | 'Inline-table' workaround for <ruby> broken with ruby support | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Roland Steiner <rolandsteiner> | ||||
| Component: | Layout and Rendering | Assignee: | Roland Steiner <rolandsteiner> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Major | CC: | commit-queue | ||||
| Priority: | P1 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Roland Steiner
2010-03-29 21:02:45 PDT
Created attachment 52003 [details]
patch - use ruby rendering only if 'display' hasn't been altered
Patch: Instantiate ruby renderers only if 'display' value is either 'inline' or 'block'. Don't use ruby renderers for other display values such as 'inline-table'.
Comment on attachment 52003 [details] patch - use ruby rendering only if 'display' hasn't been altered Rejecting patch 52003 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 2 patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/ruby/ruby-inline-table.html patching file LayoutTests/platform/mac/fast/ruby/ruby-inline-table-expected.checksum patch: **** Only garbage was found in the patch input. patching file LayoutTests/platform/mac/fast/ruby/ruby-inline-table-expected.txt patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/rendering/RenderObject.cpp Full output: http://webkit-commit-queue.appspot.com/results/1581103 Landed as rev. 56890. |