[chromium] Many new test results are needed due to recent check-ins.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Levin]

There were several check-ins recently that changed pixel results or added new tests which fail for chromium, so this bug is about handling all of those.

[David Levin]

Created attachment 51995 [details]
Proposed fix.

[Dimitri Glazkov (Google)]

Comment on attachment 51995 [details]
Proposed fix.

ok.

[David Levin]

Comment on attachment 51995 [details]
Proposed fix.

Clearing r+ due to landing this as http://trac.webkit.org/changeset/56758

(Not resolving the bug yet because there are likely some more rebaselines needed.)

[David Levin]

Created attachment 52004 [details]
Proposed fix.

[David Levin]

Comment on attachment 52004 [details]
Proposed fix.

Due to bad inspector baseline.

[David Levin]

Created attachment 52006 [details]
Proposed fix (part 2).

[Shinichiro Hamaji]

Comment on attachment 52006 [details]
Proposed fix (part 2).

LGTM!

[David Levin]

Comment on attachment 52006 [details]
Proposed fix (part 2).

Clearing r+. Committed as http://trac.webkit.org/changeset/56766

[David Levin]

Created attachment 52008 [details]
Proposed fix (part 3).

Hopefully the last one. I missed this change last time.

[Adam Barth]

Comment on attachment 52008 [details]
Proposed fix (part 3).

ok.  we need to automate this.

[David Levin]

Should be completely fixed now: http://trac.webkit.org/changeset/56771

[Daniel Bates]

We decided to rollout the patch for bug #9268 (committed in change set 56655, <http://trac.webkit.org/changeset/57287>) since it caused regressions in some of the mozilla- and mozilla expected failure- tests. See bug #9268 for more details.

[Daniel Bates]

Created attachment 52888 [details]
Partial rollout: mozilla- and mozilla_expected_failures tests

Partial rollout of 56766.

Patch to roll out the changes to the mozilla- and mozilla_expected_failures- tests committed in change set 56766 since we rolled out the change committed in change set 56655, <http://trac.webkit.org/changeset/56655> (in change set 57287, <http://trac.webkit.org/changeset/57287>). See bug #9268 for more details.

[Daniel Bates]

Created attachment 52891 [details]
Rollout 56771

Rollout change set 56771 since we rolled out the change committed in change set 56655, <http://trac.webkit.org/changeset/56655> (in change set 57287, <http://trac.webkit.org/changeset/57287>). See bug #9268 for more details.

[Ojan Vafai]

Created attachment 52893 [details]
Patch

[Daniel Bates]

Comment on attachment 52893 [details]
Patch


> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
> +        * platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:

I take it you have confirmed these also regressed.

Looks sane to me otherwise.

r=me

[Ojan Vafai]

Committed r57291: <http://trac.webkit.org/changeset/57291>

[Ojan Vafai]

Created attachment 52897 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 52897 [details]
Patch

ok.

[Ojan Vafai]

Committed r57293: <http://trac.webkit.org/changeset/57293>

[WebKit Review Bot]

http://trac.webkit.org/changeset/57293 might have broken SnowLeopard Intel Release (Tests)