| Summary: | [Qt, Gtk] Allows build-webkit script to accept custom make command as parameter | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rodrigo Belem <rclbelem> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED LATER | ||||||
| Severity: | Enhancement | CC: | diegohcg, gustavo, hausmann, kenneth, laszlo.gombos, mrobinson, tonikitoo, zan | ||||
| Priority: | P2 | Keywords: | Gtk, Qt, QtTriaged | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
Created attachment 51971 [details]
Patch that adds the --make option.
Adding the keywords qt and gtk. I made a mistake. (In reply to comment #0) > The build-webkit script lacks for a parameter to set a custom make command. > > A debian/rules snippet as a real world example. > > build-stamp: > dh_testdir > > WebKitTools/Scripts/build-webkit --qt --make=$(QMAKE) > I mean --make=$(MAKE) where I wrote --make=$(QMAKE) How is this different from --makeargs= ? You want to use another make? like gmake? qmake is not a replacement for make, but a companion. (In reply to comment #4) > How is this different from --makeargs= ? You want to use another make? like > gmake? > When building the qtwebkit debian package with the command dpkg-buildpackage -rfakeroot -j15 and using --makeargs=$(MAKEFLAGS) as following WebKitTools/Scripts/build-webkit --qt --makeargs=$(MAKEFLAGS) It does not passes the -j15 correctly to the make command. With the attached patch and the following command in the debian/rules, it works as desired. WebKitTools/Scripts/build-webkit --qt --make=$(MAKE) > qmake is not a replacement for make, but a companion. Sorry. That was a typo. (In reply to comment #5) > When building the qtwebkit debian package with the command > > dpkg-buildpackage -rfakeroot -j15 > > and using --makeargs=$(MAKEFLAGS) as following > > WebKitTools/Scripts/build-webkit --qt --makeargs=$(MAKEFLAGS) > > It does not passes the -j15 correctly to the make command. With the attached > patch and the following command in the debian/rules, it works as desired. Why not fix the usage of --makeargs, instead, then? I am assuming it should work for your case (in fact, using -j was precisely why it got added in the first place). Comment on attachment 51971 [details] Patch that adds the --make option. (In reply to comment #6) > (In reply to comment #5) > > When building the qtwebkit debian package with the command > > > > dpkg-buildpackage -rfakeroot -j15 > > > > and using --makeargs=$(MAKEFLAGS) as following > > > > WebKitTools/Scripts/build-webkit --qt --makeargs=$(MAKEFLAGS) > > > > It does not passes the -j15 correctly to the make command. With the attached > > patch and the following command in the debian/rules, it works as desired. > > Why not fix the usage of --makeargs, instead, then? I am assuming it should > work for your case (in fact, using -j was precisely why it got added in the > first place). I agree, fixing the quoting sounds like the better thing to do. Rodrigo do you want to assign this one to you? Is there still interest in getting this done? I'm thinking this isn't a big problem any longer, since no one has complained or submitted a fix. |
The build-webkit script lacks for a parameter to set a custom make command. A debian/rules snippet as a real world example. build-stamp: dh_testdir WebKitTools/Scripts/build-webkit --qt --make=$(QMAKE) This enables the dpkg-buildpackage get the make arguments, like -j parameter for distributed builds.