Bug 36781

Summary:

[chromium] Enable fast/events/onbeforeunload-focused-iframe.html

Product:

WebKit

Reporter:

Charles Reis <creis>

Component:

Tools / Tests

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed fix	levin: review-
Proposed fix, revision 2	levin: review+, commit-queue: commit-queue-
Proposed fix, revision 3	none

Charles Reis

Reported 2010-03-29 13:55:56 PDT

The onbeforeunload-focused-iframe.html layout test was disabled for Chromium until TestShell's LayoutTestController was updated to support it. That's been fixed, so we can enable this test now.

Attachments
Proposed fix (1.27 KB, patch) 2010-03-30 15:41 PDT, Sterling Swigart	levin: review-	Details Formatted Diff Diff
Proposed fix, revision 2 (1.28 KB, patch) 2010-03-30 16:12 PDT, Sterling Swigart	levin: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Proposed fix, revision 3 (1.28 KB, patch) 2010-03-31 09:14 PDT, Sterling Swigart	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Sterling Swigart

Comment 1 2010-03-30 15:41:18 PDT

Created attachment 52091 [details] Proposed fix

David Levin

Comment 2 2010-03-30 15:58:45 PDT

Comment on attachment 52091 [details] Proposed fix > diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog > + * platform/chromium/test_expectations.txt: Enable test now that callShouldCloseOnWebView > + is implemented in test_shell. This is great except for the TAB here. Please get rid of it and upload and I'll r+,cq+ it for you.

Sterling Swigart

Comment 3 2010-03-30 16:12:43 PDT

Created attachment 52095 [details] Proposed fix, revision 2

WebKit Commit Bot

Comment 4 2010-03-31 02:16:31 PDT

Comment on attachment 52095 [details] Proposed fix, revision 2 Rejecting patch 52095 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: sts/platform/chromium/test_expectations.txt A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following files contain tab characters: trunk/LayoutTests/ChangeLog Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://webkit-commit-queue.appspot.com/results/1618107

Sterling Swigart

Comment 5 2010-03-31 09:14:55 PDT

Created attachment 52179 [details] Proposed fix, revision 3

WebKit Commit Bot

Comment 6 2010-03-31 09:53:25 PDT

Comment on attachment 52179 [details] Proposed fix, revision 3 Clearing flags on attachment: 52179 Committed r56848: <http://trac.webkit.org/changeset/56848>

WebKit Commit Bot

Comment 7 2010-03-31 09:53:30 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.