Summary: | Add sign in/out link to TestResults appengine | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Victor Wang <victorw> | ||||||||
Component: | Tools / Tests | Assignee: | Victor Wang <victorw> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, commit-queue, dglazkov, ojan | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Victor Wang
2010-03-29 11:44:52 PDT
Created attachment 51941 [details]
Proposed Patch
Created attachment 51942 [details]
Proposed Patch
Comment on attachment 51942 [details] Proposed Patch > + user = users.get_current_user() > + if user: > + user_email = user.email() > + sign = "Sign out" > + sign_url = users.create_logout_url(self.request.uri) How about calling these login_text and login_url? "sign" could mean other things. > +.sign { s/sign/login ? Otherwise, looks good. Comment on attachment 51942 [details]
Proposed Patch
Please address Ojan's feedback.
Created attachment 51963 [details]
Proposed Patch
names updated. please take a look.
Comment on attachment 51963 [details]
Proposed Patch
LGTM
Comment on attachment 51963 [details] Proposed Patch Clearing flags on attachment: 51963 Committed r56753: <http://trac.webkit.org/changeset/56753> All reviewed patches have been landed. Closing bug. |