Bug 36767 – Add sign in/out link to TestResults appengine

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Victor Wang]

Add a link to TestResults appengine so admin can sign in and sign out.

TestResults appengine allows admins to view/do extra stuffs that normal users won't be able to. For example, admin can see a "delete" link next to a file and has the privilege to delete a file.

[Victor Wang]

Created attachment 51941 [details]
Proposed Patch

[Victor Wang]

Created attachment 51942 [details]
Proposed Patch

[Ojan Vafai]

Comment on attachment 51942 [details]
Proposed Patch

> +        user = users.get_current_user()
> +        if user:
> +            user_email = user.email()
> +            sign = "Sign out"
> +            sign_url = users.create_logout_url(self.request.uri)

How about calling these login_text and login_url? "sign" could mean other things.

> +.sign {

s/sign/login ?

Otherwise, looks good.

[Adam Barth]

Comment on attachment 51942 [details]
Proposed Patch

Please address Ojan's feedback.

[Victor Wang]

Created attachment 51963 [details]
Proposed Patch

names updated. please take a look.

[Adam Barth]

Comment on attachment 51963 [details]
Proposed Patch

LGTM

[WebKit Commit Bot]

Comment on attachment 51963 [details]
Proposed Patch

Clearing flags on attachment: 51963

Committed r56753: <http://trac.webkit.org/changeset/56753>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.