Bug 36754

Summary:

[GTK] webkit_get_default_session() should make sure webkit_init() is called

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

xan.lopez

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
proposed fix	zecke: review+, gustavo: commit-queue-

Gustavo Noronha (kov)

Reported 2010-03-29 06:46:47 PDT

While writing an application that does not create a WebView early in its life, but that does all of the setup right away, I noticed my removal of the soup auth dialog feature was not having any effect. That is because webkit_init was not called much later, when the first WebView is created, and then adds the feature I tried to remove. I have solved this by creating, and destroying a WebView while setting up the session (ugh).

Attachments
proposed fix (6.44 KB, patch) 2010-03-29 07:43 PDT, Gustavo Noronha (kov)	zecke: review+ gustavo: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gustavo Noronha (kov)

Comment 1 2010-03-29 07:43:33 PDT

Created attachment 51907 [details] proposed fix

Holger Freyther

Comment 2 2010-03-31 02:14:25 PDT

Comment on attachment 51907 [details] proposed fix > +// Make sure the session is initialized properly when webkit_get_default_session() is called. > +static void test_globals_default_session() > +{ I think you want to call g_test_bug("36754"); here. Besides that the webkit_init call will call get_default_session and set_cache_model but that is fine as we have an early exit in there.

Gustavo Noronha (kov)

Comment 3 2010-04-01 09:07:43 PDT

Landed as r56916.

Note You need to log in before you can comment on or make changes to this bug.