Summary: | [Qt] Windows CE build is broken | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Hausmann <hausmann> | ||||||
Component: | New Bugs | Assignee: | Simon Hausmann <hausmann> | ||||||
Status: | CLOSED FIXED | ||||||||
Severity: | Blocker | CC: | commit-queue, ismail, jturcotte, laszlo.gombos | ||||||
Priority: | P1 | Keywords: | Qt | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | Other | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 35784 | ||||||||
Attachments: |
|
Description
Simon Hausmann
2010-03-29 03:31:25 PDT
Created attachment 51896 [details]
Patch
(In reply to comment #1) > Created an attachment (id=51896) [details] > Patch + +# DEFINES += ENABLE_SVG=0 ENABLE_XPATH=0 ENABLE_XBL=0 \ +# ENABLE_SVG_ANIMATION=0 ENABLE_SVG_USE=0 \ +# ENABLE_SVG_FOREIGN_OBJECT=0 ENABLE_SVG_AS_IMAGE=0 those seems unrelated. Patch fixes the compilation error for me, thanks. Comment on attachment 51896 [details]
Patch
Can we remove the:
# DEFINES += ENABLE_SVG=0 ENABLE_XPATH=0 ENABLE_XBL=0 \
59 # ENABLE_SVG_ANIMATION=0 ENABLE_SVG_USE=0 \
60 # ENABLE_SVG_FOREIGN_OBJECT=0 ENABLE_SVG_AS_IMAGE=0
The commented out code seems usless.
Created attachment 53454 [details]
Patch v2
Upstreaming the patch currently in qt/src/3rdparty/webkit
The same as the previous patch except the commented part has been removed
I can't really review a patch with my own name in it, but it looks good to me ;) Comment on attachment 51896 [details] Patch Cleared Eric Seidel's review+ from obsolete attachment 51896 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 53454 [details]
Patch v2
lgtm as well, r+.
Comment on attachment 53454 [details] Patch v2 Clearing flags on attachment: 53454 Committed r57802: <http://trac.webkit.org/changeset/57802> All reviewed patches have been landed. Closing bug. Revision r57802 cherry-picked into qtwebkit-2.0 with commit 2ccb40583521dc3a8744555663359671a28aaa2a |