Summary: | GW: Add CGPoint and other small fixes to KWQPoint* | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Enhancement | ||||||||||||
Priority: | P4 | ||||||||||||
Version: | 412 | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.4 | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 3250 | ||||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2005-06-23 03:10:19 PDT
Created attachment 2578 [details]
Adds CGPoint support, as well as various other small fixes
Please pardon the few additional white-space changes. I ran a "re-indent"
command over the entire file to replace tabs w/ spaces... it added a few spaces
where there were not before.
Comment on attachment 2578 [details]
Adds CGPoint support, as well as various other small fixes
The operator * implementation does not match our coding style. The "{" should
be on a second line.
The implementation of isNull() has some extra punctuation and spaces in it.
Should just be "return xCoord == 0 && yCoord == 0;".
There are extra spaces in the setPoints call inside the QPointArray constructor
that takes a QRect. I know that matches the existing constructor, but it does
not match our coding cuidelines.
In QPointArray::copy, it would be better to use a static_cast rather than a
C-style cast.
The boundingRect and point functions have the "{" o the same line as the
function declaration, but it should be on the next line.
The call to QMemArray<QPoint>::at(index) inside QPointArray::point, should just
be a call to at(index).
Created attachment 2604 [details]
Formatting oversights now fixed.
Comment on attachment 2604 [details]
Formatting oversights now fixed.
Forward declaration of class QRect should be at the top of the file.
No space after "-=" in operator -= declaration.
When importing things in the KWQ directory, don't use forwarding headers. Hence
it should be:
#import "KWQRect.h"
Otherwise, looks fine.
Created attachment 2713 [details]
addressed Darin's concerns
Is it just me, or does this never use minX > 0, minY > 0 for the top-left corner of the rectangle? Created attachment 2824 [details]
Addressed SadEagle's boundingRect() concern.
Comment on attachment 2713 [details]
addressed Darin's concerns
Replaced patch to fix SadEagle's boundingRect() concerns.
r=me |