Bug 36733

Summary:

Use a common header for Windows virtual key codes on all platforms

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebCore Misc.

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed patch	none
proposed patch	sam: review+

Description Alexey Proskuryakov 2010-03-28 13:49:30 PDT

Currently, we have multiple headers define VK_* key codes. There is no reason for that, they are all the same and match Windows.

Comment 1 Alexey Proskuryakov 2010-03-28 14:03:38 PDT

Created attachment 51867 [details]
proposed patch

Comment 2 Alexey Proskuryakov 2010-03-28 14:48:54 PDT

Created attachment 51869 [details]
proposed patch

Updated to apply to ToT.

Comment 3 Sam Weinig 2010-03-28 18:20:57 PDT

Comment on attachment 51869 [details]
proposed patch

In the words of Mark Rowe, "awesomesauce".

Comment 4 Alexey Proskuryakov 2010-03-28 20:41:53 PDT

Committed revision 56704.

i saw that EWS complained about Qt build, but it didn't tell what was wrong.