Summary: | GW: Add QBuffer::setBuffer(QByteArray) support to KWQBuffer | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
Component: | New Bugs | Assignee: | Dave Hyatt <hyatt> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | ||||||||||
Priority: | P3 | ||||||||||
Version: | 412 | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.4 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 3250 | ||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2005-06-23 02:56:26 PDT
Created attachment 2577 [details]
Adds setBuffer() support and a QByteArray based constructor
Comment on attachment 2577 [details]
Adds setBuffer() support and a QByteArray based constructor
Formatting of QBuffer::setBuffer does not match our coding guidelines. The "{"
should be on the line after the declaration, not on the same line. Also, the
"if (isOpen()) return false;" should be broken into two lines rather than
together on one.
Other than the coding guidelines issue, this looks great.
Created attachment 2589 [details]
Formatting oversights now fixed.
Comment on attachment 2589 [details]
Formatting oversights now fixed.
The parameter to the QBuffer constructor should be QByteArray, not QByteArray
&, to match Qt.
If it's going to be a reference, then I suggest that we make it const
QByteArray & and do the same with the parameter to setBuffer.
Otherwise, looks good.
Created attachment 2606 [details]
Fixed QByteArray &
Comment on attachment 2606 [details]
Fixed QByteArray &
r=me
|