Bug 36719

Summary: Web Inspector: Consolidate Tree Hierarchy Attribute HTML Generation
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Consolidate to _attributeHTML pfeldman: review+

Description Joseph Pecoraro 2010-03-28 03:12:18 PDT
Attribute HTML is generated in 3 different places:
- updateTitle the core location (name+value, linkifies, and tooltips)
- _addNewAttribute (blank name+value, no equals or quotes)
- regenerateStyledAttribute (when tabbing, name+value, no linkify)

These can become out of sync. They should be consolidated.
Comment 1 Joseph Pecoraro 2010-03-28 03:14:35 PDT
Created attachment 51854 [details]
[PATCH] Consolidate to _attributeHTML
Comment 2 Joseph Pecoraro 2010-03-28 03:36:35 PDT
Committed r56688
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
r56688 = 0b5ebc1a1afceb39553d882c9e6fb64e4bb8cb72 (trunk)
http://trac.webkit.org/changeset/56688