Bug 36701 – Fix tests added by https://bugs.webkit.org/show_bug.cgi?id=36675 on Qt Linux and Windows

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Robert Hogan]

Add support to unix and windows NS plugin for executing scripts on setWindow.

Amend plugins/reentrant-update-widget-positions.html to trigger the test in the same way as its companion test update-widgets-crash.html, i.e.:

window.addEventListener('load', doTest, false);

reentrant-update-widget-positions.html was using:

    window.addEventListener('load', function() {
        window.setTimeout(doTest, 0);

which on Qt (and apparently Windows judging by the bot) runs the test after onSetWindow has been called. There must be a bug at the bottom of this difference but probably best to treat separately.

[Robert Hogan]

Created attachment 51827 [details]
Patch

[WebKit Review Bot]

Attachment 51827 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:89:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/win/TestNetscapePlugin/main.cpp:111:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Robert Hogan]

See https://bugs.webkit.org/show_bug.cgi?id=36702 for tracking the inconsistency in EventListener/setTimeOut.

[Robert Hogan]

(In reply to comment #2)
> Attachment 51827 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebKitTools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:89: 
> Tests for true/false, null/non-null, and zero/non-zero should all be done
> without equality comparisons.  [readability/comparison_to_zero] [5]
> WebKitTools/DumpRenderTree/win/TestNetscapePlugin/main.cpp:111:  Tests for
> true/false, null/non-null, and zero/non-zero should all be done without
> equality comparisons.  [readability/comparison_to_zero] [5]
> Total errors found: 2 in 5 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

Ignoring these errors as the style is consistent with the rest of the file.

[Simon Fraser (smfr)]

Comment on attachment 51827 [details]
Patch

> Subject: [PATCH] 2010-03-27  Robert Hogan  <[e-mail]>
> 
>         Reviewed by NOBODY (OOPS!).
> 
>         Amend plugins/reentrant-update-widget-positions.html to trigger the test in the
>         same way as its companion test plugins/update-widgets-crash.html, i.e.:

The tests are different for the specific reason that they triggered different bugs. Please leave them as they are.

r=me on the plugin code changes.

[Alexey Proskuryakov]

Comment on attachment 51827 [details]
Patch

Marking cq-, because this patch shouldn't be landed as is.

[Eric Seidel (no email)]

Attachment 51827 [details] was posted by a committer and has review+, assigning to Robert Hogan for commit.

[Robert Hogan]

Landed as r56668.