| Summary: | Rename QTKit based media engine class name | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, ademar, eric, pnormand, rniwa, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.6 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 51249 | ||||||
| Attachments: |
|
||||||
|
Description
Eric Carlson
2010-03-26 08:35:29 PDT
Additionnally I think it would be good to have a WTF_USE_... define to enable the QTKit player and same for QuickTime (or whatever is currently used on the windows port). Qt backends were renamed in <http://trac.webkit.org/changeset/68526> http://trac.webkit.org/changeset/68526 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/68523 http://trac.webkit.org/changeset/68524 http://trac.webkit.org/changeset/68525 http://trac.webkit.org/changeset/68526 http://trac.webkit.org/changeset/68527 http://trac.webkit.org/changeset/68528 http://trac.webkit.org/changeset/68529 http://trac.webkit.org/changeset/68530 http://trac.webkit.org/changeset/68531 Created attachment 73830 [details]
Proposed patch
Comment on attachment 73830 [details]
Proposed patch
Marking this attachment as a patch since it is a patch and it is flagged for review. Moreover, this will cause the EWS bots to build with this patch.
This change might be responsible for some test failures: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r72115%20(20918)/results.html All of the failures seem to be caused by failing to load some resource. Could you look into this? (In reply to comment #7) > This change might be responsible for some test failures: > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r72115%20(20918)/results.html > > All of the failures seem to be caused by failing to load some resource. Could you look into this? Oops, this was a false alert. The failure was caused by r72115, not r72117. Sorry. This changed the name of the OS X media engine class. The code change is *only* used by HTMLMediaElement, it has absolutely nothing to do with the loader. Revision r68526 cherry-picked into qtwebkit-2.2 with commit 600bc9b <http://gitorious.org/webkit/qtwebkit/commit/600bc9b> |