Bug 36638

Summary:

Commit bot tried to land r? cq+ patch

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
should work, needs testing	none
Patch	none

Julien Chaffraix

Reported 2010-03-25 19:09:43 PDT

Found in https://bugs.webkit.org/show_bug.cgi?id=36531 After having attached a patch for review and set the cq to +, the bot tried to land the patch directly and failed due to not finding any reviewer. When posting the second patch, the first patch was still r? but I obsoleted it. The new patch original flags were r? and cq+.

Attachments
should work, needs testing (1.79 KB, patch) 2011-01-09 15:23 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch (6.01 KB, patch) 2011-01-10 01:56 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2010-03-26 16:46:34 PDT

If you mark a patch commit-queue+, the bot will try to land it. If it wasn't reviewed, it doesn't sound like it's ready for commit. Why did you mark it commit-queue+?

Eric Seidel (no email)

Comment 2 2010-03-26 16:48:04 PDT

Oh posh. I think we should handle this case. We should not try to land patches which still have r? or which are marked r-. Only empty review or r+.

Julien Chaffraix

Comment 3 2010-03-26 16:55:49 PDT

(In reply to comment #1) > If you mark a patch commit-queue+, the bot will try to land it. If it wasn't > reviewed, it doesn't sound like it's ready for commit. Why did you mark it > commit-queue+? Simple, because I wanted the bot to land it for me (I usually land my patches manually to deal with the fallout). This one was special: it was a test fix so it was better to get it landed ASAP. I have barely used the commit bot so my naive thought was that the bot would just wait until was reviewed to land it.

Eric Seidel (no email)

Comment 4 2011-01-09 15:23:41 PST

Created attachment 78357 [details] should work, needs testing

Adam Barth

Comment 5 2011-01-09 15:53:31 PST

Comment on attachment 78357 [details] should work, needs testing Looks right.

Eric Seidel (no email)

Comment 6 2011-01-10 01:56:38 PST

Created attachment 78381 [details] Patch

Adam Barth

Comment 7 2011-01-10 02:09:30 PST

Comment on attachment 78381 [details] Patch Now, this patch, on the other hand, is very nice.

WebKit Commit Bot

Comment 8 2011-01-10 03:21:55 PST

Comment on attachment 78381 [details] Patch Clearing flags on attachment: 78381 Committed r75366: <http://trac.webkit.org/changeset/75366>

WebKit Commit Bot

Comment 9 2011-01-10 03:22:00 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.