Bug 36619

Summary: new-run-webkit-tests should use a test_expectations file in addition to Skipped files so we can handle pixel failures
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: cjerdonek, eric, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch eric: review+

Dirk Pranke
Reported 2010-03-25 14:31:43 PDT
Skipped files give us no way to track pixel failures separately from other types of failures. If we start using a test_expectations.txt file we can track these and get a clean test run both with and without pixel tests enabled.
Attachments
patch (6.89 KB, patch)
2010-03-25 14:41 PDT, Dirk Pranke 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-03-25 14:41:05 PDT
Created attachment 51677 [details] patch
Eric Seidel (no email)
Comment 2 2010-03-25 14:42:29 PDT
Comment on attachment 51677 [details] patch Maybe that should go in mac-leopard? LGTM.
Dirk Pranke
Comment 3 2010-03-25 14:58:01 PDT
test_expectations files should generally be as portable as possible, because maintaining multiple versions is a hassle, and one hopes that most bugs are cross-platform/cross-version, rather than version-specific.
Dirk Pranke
Comment 4 2010-03-26 17:15:30 PDT
Committed r56648: <http://trac.webkit.org/changeset/56648>
Note You need to log in before you can comment on or make changes to this bug.