Bug 36602

Summary: [chromium] linux: prefer the "hinting" fontconfig preference.
Product: WebKit Reporter: Adam Langley <agl>
Component: Layout and RenderingAssignee: Adam Langley <agl>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, evan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch levin: review+, levin: commit-queue-

Adam Langley
Reported 2010-03-25 07:56:26 PDT
fontconfig can give contradictory hinting information, setting "hinting" to zero and "hintstyle" to non-zero. In this case we should take the "hinting" preference.
Attachments
patch (7.32 KB, patch)
2010-03-25 08:04 PDT, Adam Langley 		levin: review+
levin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Langley
Comment 1 2010-03-25 08:04:14 PDT
Created attachment 51641 [details] patch
Evan Martin
Comment 2 2010-03-25 08:18:59 PDT
LGTM
David Levin
Comment 3 2010-03-25 09:50:35 PDT
Comment on attachment 51641 [details] patch > diff --git a/WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp b/WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp > + default: > + paint->setHinting((SkPaint::Hinting) m_style.hintStyle); Please use C++ style casting like this: paint->setHinting(static_cast<SkPaint::Hinting>(m_style.hintStyle));
Eric Seidel (no email)
Comment 4 2010-03-29 11:40:06 PDT
Attachment 51641 [details] was posted by a committer and has review+, assigning to Adam Langley for commit.
Eric Seidel (no email)
Comment 5 2010-05-17 00:45:26 PDT
Unsure of the status of this patch. It's been in pending-commit for over a month. Updates?
Tony Chang
Comment 6 2010-05-17 00:49:06 PDT
(In reply to comment #5) > Unsure of the status of this patch. It's been in pending-commit for over a month. Updates? This was landed in http://trac.webkit.org/changeset/56800.
Note You need to log in before you can comment on or make changes to this bug.