Summary: | [v8] Add if ENABLE guard for Worker specific code. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kristian Monsen <kristianm> | ||||
Component: | WebCore Misc. | Assignee: | Ben Murdoch <benm> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | android-webkit-unforking, benm, levin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Android | ||||||
OS: | Android | ||||||
Attachments: |
|
Description
Kristian Monsen
2010-03-25 07:17:06 PDT
Created attachment 51639 [details]
Patch number 1
Comment on attachment 51639 [details] Patch number 1 > Index: WebCore/ChangeLog > +2010-03-25 Kristian Monsen <kristianm@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Guarding the function in the header as well. I'll r+ *but* before committing the patch this line should be changed to the (new) title of the bug (a WK committer can do this for you right before they commit the change and I think you have a few nearby). The problem is that right now this line doesn't tell you anything. Ideally one should be able to read this and get a sense of what was addressed (so folks can decide to look at the details or not -- think of it like a good email subject). OK, thanks for the comment. I will update this bug and improve for next patch. Will update Changelog as per review comments and land. Sending WebCore/ChangeLog Sending WebCore/bindings/v8/V8DOMWrapper.h Transmitting file data .. Committed revision 56778. |