Bug 36590

Summary: [Qt] Build JavaScriptCore as a static library
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: Tools / TestsAssignee: Jocelyn Turcotte <jturcotte>
Status: CLOSED FIXED    
Severity: Enhancement CC: hausmann, ismail
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 37701    
Bug Blocks: 35784    
Attachments:
Description Flags
Patch
none
Patch v2 hausmann: review+

Jocelyn Turcotte
Reported 2010-03-25 03:49:15 PDT
Currently, JavaScriptCore is build by including JavaScriptCore.pri in WebCore.pro, jsc.pro and QtScript.pro. This .pri file just add JavaScriptCore's cpp files to the SOURCES variable. Building JavaScriptCore statically before would prevent recompiling JavaScriptCore's cpp files for each project and would allow its objects files to be compiled with different optimization flags.
Attachments
Patch (19.38 KB, patch)
2010-03-25 03:52 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Patch v2 (19.00 KB, patch)
2010-03-25 04:16 PDT, Jocelyn Turcotte 		hausmann: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2010-03-25 03:52:10 PDT
Created attachment 51620 [details] Patch
Jocelyn Turcotte
Comment 2 2010-03-25 04:16:52 PDT
Created attachment 51627 [details] Patch v2 Removes unrelated hunk.
Simon Hausmann
Comment 3 2010-03-26 08:51:31 PDT
Committed r56623: <http://trac.webkit.org/changeset/56623>
Simon Hausmann
Comment 4 2010-03-26 08:53:43 PDT
Revision r56623 cherry-picked into qtwebkit-2.0 with commit b9a9ed485914673c4801be819f8906e933666435
Ismail Donmez
Comment 5 2010-03-27 03:15:46 PDT
This breaks the WinCE build (reverting the commit fixes the build ), I get: pcre_compile.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_exec.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_tables.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_ucp_searchfuncs.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_xclass.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory Looks like JavaScriptCore/os-win32 is not being added to includepath.
Simon Hausmann
Comment 6 2010-03-29 03:31:51 PDT
(In reply to comment #5) > This breaks the WinCE build (reverting the commit fixes the build ), I get: Filed #36751
Simon Hausmann
Comment 7 2010-03-29 03:32:10 PDT
(In reply to comment #6) > (In reply to comment #5) > > This breaks the WinCE build (reverting the commit fixes the build ), I get: > > Filed #36751 Err https://bugs.webkit.org/show_bug.cgi?id=36751
Note You need to log in before you can comment on or make changes to this bug.