Bug 36582

Summary: REGRESSION: webkit-patch land can't land "rubber-stamped" patches
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Eric Seidel (no email) 2010-03-25 00:07:29 PDT 
REGRESSION: webkit-patch land can't land "rubber-stamped" patches

I don't think land should be nearly so strict in the manual use case.  It should probably just warn.
Comment 1 Adam Barth 2010-03-25 15:46:40 PDT 
Fixed in http://trac.webkit.org/changeset/56554
Comment 2 Eric Seidel (no email) 2010-03-25 15:54:46 PDT 
Sigh.  I don't think that we should be prescribing "rubber stamp".  It's common for folks to use "rubber-stamped".
Comment 3 Adam Barth 2010-03-25 16:33:23 PDT 
ok
Comment 4 Adam Barth 2010-03-25 16:34:24 PDT 
Created attachment 51690 [details]
Patch
Comment 5 Eric Seidel (no email) 2010-03-25 16:37:34 PDT 
Comment on attachment 51690 [details]
Patch

I still think this is error prone.  I'm also saddened by lack of testing on this step.
Comment 6 Adam Barth 2010-03-25 16:42:30 PDT 
Comment on attachment 51690 [details]
Patch

Yeah.  It's a bit of an experiment.  We might need to try a different approach at some point.
Comment 7 WebKit Commit Bot 2010-03-25 19:21:15 PDT 
Comment on attachment 51690 [details]
Patch

Clearing flags on attachment: 51690

Committed r56589: <http://trac.webkit.org/changeset/56589>
Comment 8 WebKit Commit Bot 2010-03-25 19:21:20 PDT 
All reviewed patches have been landed.  Closing bug.