|Summary:||Make calls to m_keyframeAnimations.checkConsistency() debug-only|
|Product:||WebKit||Reporter:||Simon Fraser (smfr) <simon.fraser>|
|Component:||Layout and Rendering||Assignee:||Simon Fraser (smfr) <simon.fraser>|
|Severity:||Normal||CC:||ap, cmarrin, darin|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Simon Fraser (smfr) 2010-03-24 14:04:52 PDT
Animation code has a bunch of calls to m_keyframeAnimations.checkConsistency() that are in release builds. These should be debug-only.
Comment 1 Simon Fraser (smfr) 2010-03-24 14:05:15 PDT
Or we should remove them.
Comment 2 Alexey Proskuryakov 2010-03-24 17:08:50 PDT
These are supposed to be no-ops in release builds. Are they not? We don't usually add ifdef NDEBUG at each call site if function name clearly indicates that it's debug-only, and has such ifdefs inside.
Comment 4 Simon Fraser (smfr) 2010-03-25 12:57:09 PDT
Comment on attachment 51669 [details] Patch r=ericc
Comment 6 Darin Adler 2010-03-25 13:59:26 PDT
The premise of this bug was wrong, I think. The code is already debug-only.
Comment 7 Simon Fraser (smfr) 2010-03-25 14:23:55 PDT
Reopening to revert the change.