Bug 36555

Summary: Make calls to m_keyframeAnimations.checkConsistency() debug-only
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, cmarrin, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch simon.fraser: review+

Simon Fraser (smfr)
Reported 2010-03-24 14:04:52 PDT
Animation code has a bunch of calls to m_keyframeAnimations.checkConsistency() that are in release builds. These should be debug-only.
Attachments
Patch (6.67 KB, patch)
2010-03-25 12:14 PDT, Simon Fraser (smfr) 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-03-24 14:05:15 PDT
Or we should remove them.
Alexey Proskuryakov
Comment 2 2010-03-24 17:08:50 PDT
These are supposed to be no-ops in release builds. Are they not? We don't usually add ifdef NDEBUG at each call site if function name clearly indicates that it's debug-only, and has such ifdefs inside.
Simon Fraser (smfr)
Comment 3 2010-03-25 12:14:43 PDT
Created attachment 51669 [details] Patch
Simon Fraser (smfr)
Comment 4 2010-03-25 12:57:09 PDT
Comment on attachment 51669 [details] Patch r=ericc
Simon Fraser (smfr)
Comment 5 2010-03-25 12:58:09 PDT
http://trac.webkit.org/changeset/56565
Darin Adler
Comment 6 2010-03-25 13:59:26 PDT
The premise of this bug was wrong, I think. The code is already debug-only.
Simon Fraser (smfr)
Comment 7 2010-03-25 14:23:55 PDT
Reopening to revert the change.
Simon Fraser (smfr)
Comment 8 2010-03-25 14:34:53 PDT
Backed out in http://trac.webkit.org/changeset/56568.
Note You need to log in before you can comment on or make changes to this bug.