Bug 36554

Summary: Web Inspector: reloading debug target window with cmd-R from inspector window produces beep.
Product: WebKit Reporter: Mike Wilcox <mike>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Prevent Beeping
none
[PATCH] Prevent Beep only when handled pfeldman: review+, pfeldman: commit-queue-

Mike Wilcox
Reported 2010-03-24 13:53:16 PDT
- reload debug target window with cmd-R from inspector window Or in other words: You can't refresh the page with command-r if the console is it's own window and in focus. I gave an enhanced severity on this, because I believe this is the solitary feature that keeps it from being as good as Firebug.
Attachments
[PATCH] Prevent Beeping (1.14 KB, patch)
2010-03-24 21:35 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Prevent Beep only when handled (1.27 KB, patch)
2010-03-24 21:38 PDT, Joseph Pecoraro 		pfeldman: review+
pfeldman: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2010-03-24 21:34:50 PDT
Pavel is right, this works for me in the WebKit nightly. Mike which version are you using? Try updating to the latest at: http://build.webkit.org/ This does however give me an ugly beep on mac. It seems a lot of keyboard shortcuts do that on the mac. There should probably be a preventDefault() somewhere.
Joseph Pecoraro
Comment 2 2010-03-24 21:35:24 PDT
Created attachment 51591 [details] [PATCH] Prevent Beeping Like here.
Joseph Pecoraro
Comment 3 2010-03-24 21:38:04 PDT
Created attachment 51592 [details] [PATCH] Prevent Beep only when handled This is probably better!
Pavel Feldman
Comment 4 2010-03-25 00:52:24 PDT
Comment on attachment 51592 [details] [PATCH] Prevent Beep only when handled Clearing r+ since I think that commit message is wrong.
Pavel Feldman
Comment 5 2010-03-25 00:53:38 PDT
Comment on attachment 51592 [details] [PATCH] Prevent Beep only when handled Stupid me - I should have cleared cq+ only.
Pavel Feldman
Comment 6 2010-03-25 00:54:50 PDT
Re-opening the bug now that it has new title.
Joseph Pecoraro
Comment 7 2010-03-25 09:10:23 PDT
Committed r56549 M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js r56549 = 03bbfd904dce03a8bf39e339c0ec9666abbdfb48 (trunk) http://trac.webkit.org/changeset/56549
Note You need to log in before you can comment on or make changes to this bug.