Bug 36554

Summary: Web Inspector: reloading debug target window with cmd-R from inspector window produces beep.
Product: WebKit Reporter: Mike Wilcox <mike>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Prevent Beeping
none
[PATCH] Prevent Beep only when handled pfeldman: review+, pfeldman: commit-queue-

Description Mike Wilcox 2010-03-24 13:53:16 PDT 
- reload debug target window with cmd-R from inspector window

Or in other words:
You can't refresh the page with command-r if the console is it's own window and in focus.

I gave an enhanced severity on this, because I believe this is the solitary feature that keeps it from being as good as Firebug.
Comment 1 Joseph Pecoraro 2010-03-24 21:34:50 PDT 
Pavel is right, this works for me in the WebKit nightly. Mike which version are you using? Try updating to the latest at:
http://build.webkit.org/

This does however give me an ugly beep on mac. It seems a lot of keyboard shortcuts do that on the mac. There should probably be a preventDefault() somewhere.
Comment 2 Joseph Pecoraro 2010-03-24 21:35:24 PDT 
Created attachment 51591 [details]
[PATCH] Prevent Beeping

Like here.
Comment 3 Joseph Pecoraro 2010-03-24 21:38:04 PDT 
Created attachment 51592 [details]
[PATCH] Prevent Beep only when handled

This is probably better!
Comment 4 Pavel Feldman 2010-03-25 00:52:24 PDT 
Comment on attachment 51592 [details]
[PATCH] Prevent Beep only when handled

Clearing r+ since I think that commit message is wrong.
Comment 5 Pavel Feldman 2010-03-25 00:53:38 PDT 
Comment on attachment 51592 [details]
[PATCH] Prevent Beep only when handled

Stupid me - I should have cleared cq+ only.
Comment 6 Pavel Feldman 2010-03-25 00:54:50 PDT 
Re-opening the bug now that it has new title.
Comment 7 Joseph Pecoraro 2010-03-25 09:10:23 PDT 
Committed r56549
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/inspector.js
r56549 = 03bbfd904dce03a8bf39e339c0ec9666abbdfb48 (trunk)
http://trac.webkit.org/changeset/56549