Bug 36537

Summary:

fast/parser/comments.html needs some clean-up

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

Tools / Tests

Assignee:

Julien Chaffraix <jchaffraix>

Status:

RESOLVED FIXED

Severity:

Minor

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Take one: clean-up output, make all part of the test run and make it a dumpAsText test	darin: review-, jchaffraix: commit-queue-
Take two: now with the expectd file	darin: review+, jchaffraix: commit-queue-

Description Julien Chaffraix 2010-03-24 09:41:24 PDT

Looking at the output of the test, we could switch to dumpAsText. The output is confusing and some of the test is actually commented!

Patch forthcoming

Comment 1 Julien Chaffraix 2010-03-24 09:47:29 PDT

Created attachment 51515 [details]
Take one: clean-up output, make all part of the test run and make it a dumpAsText test

Comment 2 Darin Adler 2010-03-24 11:28:11 PDT

Comment on attachment 51515 [details]
Take one: clean-up output, make all part of the test run and make it a dumpAsText test

Change looks fine, but I do not see the new expected.txt file. You need to svn add that and make a new patch.

Comment 3 Julien Chaffraix 2010-03-25 07:10:19 PDT

Created attachment 51636 [details]
Take two: now with the expectd file

Comment 4 Julien Chaffraix 2010-03-30 07:14:05 PDT

Landed in r56783.