Summary: | Web Inspector: Error when highlighting JavaScript with an invalid mime type | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Alexander Pavlov (apavlov)
2010-03-24 06:50:14 PDT
Created attachment 51497 [details]
[PATCH] Proposed solution
Comment on attachment 51497 [details]
[PATCH] Proposed solution
+ if (resource.mimeTypeIsConsistentWithType())
If this thing returns true, we still might end up with no tokenizer. Should this code be moved to the SourceTokenizer where you could handle this case?
Created attachment 51506 [details]
[PATCH] Extended solution to cover all scripts, styles, and documents
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/SourceTokenizer.js M WebCore/inspector/front-end/SourceView.js M WebCore/inspector/front-end/TextEditorHighlighter.js Committed r56444 |