Bug 36517

Summary:

svg/dom/frame-related-api-during-load.html shoud be more self-descriptive.

Product:

WebKit

Reporter:

Hajime Morrita <morrita>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
patch v0 - this should be a trivial change	none
add missing change on the expectation	none

Hajime Morrita

Reported 2010-03-23 22:32:39 PDT

As pointed out at the comment on Bug 31545, the contents and expectation should be more self-descriptive, i.e. Tt should say about what to test, point bug Id or URL.

Attachments
patch v0 - this should be a trivial change (2.21 KB, patch) 2010-03-23 22:38 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
add missing change on the expectation (2.23 KB, patch) 2010-03-24 19:42 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Hajime Morrita

Comment 1 2010-03-23 22:38:10 PDT

Created attachment 51478 [details] patch v0 - this should be a trivial change

WebKit Commit Bot

Comment 2 2010-03-24 12:45:59 PDT

Comment on attachment 51478 [details] patch v0 - this should be a trivial change Rejecting patch 51478 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12537 test cases. svg/dom/frame-related-api-during-load.html -> failed Exiting early after 1 failures. 10228 tests run. 236.85s total testing time 10227 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 10 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1288006

Hajime Morrita

Comment 3 2010-03-24 19:42:32 PDT

Created attachment 51581 [details] add missing change on the expectation

Hajime Morrita

Comment 4 2010-03-24 19:44:28 PDT

Oops, The patch missed my local change - fixed. I'm so sorry about that ...

Eric Seidel (no email)

Comment 5 2010-03-24 19:44:57 PDT

Comment on attachment 51581 [details] add missing change on the expectation OK.

WebKit Commit Bot

Comment 6 2010-03-24 21:58:25 PDT

Comment on attachment 51581 [details] add missing change on the expectation Clearing flags on attachment: 51581 Committed r56486: <http://trac.webkit.org/changeset/56486>

WebKit Commit Bot

Comment 7 2010-03-24 21:58:29 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.