Summary: | fix dangling references to chromium directories and baseline paths | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, ojan, victorw | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Dirk Pranke
2010-03-20 12:06:37 PDT
Created attachment 51227 [details]
Patch
Comment on attachment 51227 [details]
Patch
excellent!
Should we also get rid of _chromium_baseline_path?
(In reply to comment #2) > (From update of attachment 51227 [details]) > excellent! > > Should we also get rid of _chromium_baseline_path? Eventually, but I don't want to get rid of it just yet. I also don't want to commit this until we get a chance to discuss http://trac.webkit.org/changeset/56307 It looks like you made a similar change to fix the rebaselining tool, but I don't understand why it would've fixed your crash. Created attachment 51355 [details]
Patch
Comment on attachment 51355 [details]
Patch
yay!
(In reply to comment #3) > I also don't want to commit this until we get a chance to discuss > > http://trac.webkit.org/changeset/56307 > > It looks like you made a similar change to fix the rebaselining tool, but I > don't understand why it would've fixed your crash. Okay, it turns out that when we tried to determine the chrome base directory, if we didn't find it, the code would return a full file path to chromium.py instead of erroring out. The revised patch will instead raise an error in this case. I've also added some better path handling to rebaseline-chromium-webkit-tests so it would work if simplejson wasn't in the PYTHONPATH by default. Ojan, Victor, can you take a look at this and make sure it looks okay? LGTM (In reply to comment #6) > (In reply to comment #3) > > I also don't want to commit this until we get a chance to discuss > > > > http://trac.webkit.org/changeset/56307 > > > > It looks like you made a similar change to fix the rebaselining tool, but I > > don't understand why it would've fixed your crash. > > Okay, it turns out that when we tried to determine the chrome base directory, > if we didn't find it, the code would return a full file path to chromium.py > instead of erroring out. The revised patch will instead raise > an error in this case. > > I've also added some better path handling to rebaseline-chromium-webkit-tests > so it would work if simplejson wasn't in the PYTHONPATH by default. > > Ojan, Victor, can you take a look at this and make sure it looks okay? Comment on attachment 51355 [details] Patch Clearing flags on attachment: 51355 Committed r56366: <http://trac.webkit.org/changeset/56366> All reviewed patches have been landed. Closing bug. |