Bug 36413

Summary:

[Qt] RenderTheme: fix size adjustment for text fields

Product:

WebKit

Reporter:

Jakub Wieczorek <jwieczorek>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Normal

CC:

euthymos, hausmann, laszlo.gombos, vestbo

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

35784

Attachments:

Description	Flags
patch	none

Description Jakub Wieczorek 2010-03-20 10:07:40 PDT

RenderThemeQt.cpp "hardcodes" the preferred dimensions for text fields but in fact it is not necessary, because WebCore already does that (20 cols x 2 rows for text areas and 20 cols x 1 row for text fields). To match other ports the size shouldn't be altered by the render theme, I believe.

Moreover, the padding for text fields is not properly applied:
- RenderTheme should also change the horizontal padding.
- it should work the same for text areas - it does not now, which causes rendering issues with the Oxygen style.

Comment 1 Jakub Wieczorek 2010-03-20 10:17:19 PDT

Created attachment 51222 [details]
patch

With this change, 3 test results had to be updated but I'm not sure if there isn't anything left to update.

Comment 2 Giacomo 2010-03-20 14:13:37 PDT

Is this related to: https://bugs.webkit.org/show_bug.cgi?id=36030 ?

Comment 3 Simon Hausmann 2010-03-21 15:48:09 PDT

Tor Arne, could you take a look at this one?

Thanks :)

Comment 4 Eric Seidel (no email) 2010-03-25 01:50:24 PDT

Comment on attachment 51222 [details]
patch

OK.

Comment 5 Jakub Wieczorek 2010-03-25 10:30:55 PDT

Comment on attachment 51222 [details]
patch

Clearing flags on attachment: 51222

Committed r56555: <http://trac.webkit.org/changeset/56555>

Comment 6 Jakub Wieczorek 2010-03-25 10:31:04 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Giacomo 2010-03-25 12:19:12 PDT

*** Bug 36030 has been marked as a duplicate of this bug. ***

Comment 8 Simon Hausmann 2010-03-26 08:41:20 PDT

Revision r56555 cherry-picked into qtwebkit-2.0 with commit cd23c453d081a795f63d594e3da8b2b580726ab7