Bug 36405

Summary: [EFL] Move AccessibilityObjectEfl.cpp from page to accessibility
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: AccessibilityAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: barbieri, cfleizach, ddkilzer, laszlo.gombos, leandro, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
(committed in r57282) patch v1 none

Laszlo Gombos
Reported 2010-03-19 20:56:08 PDT
Regarding ChangeSet r55343 (http://trac.webkit.org/changeset/55343) - Shouldn't AccessibilityObjectEfl.cpp be under accessibility directory like for other ports (e.g WebCore/accessibility/platform/efl) ?
Attachments
(committed in r57282) patch v1 (4.38 KB, patch)
2010-04-08 08:46 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-03-19 20:57:09 PDT
I meant WebCore/accessibility/efl and not WebCore/accessibility/platform/efl.
David Kilzer (:ddkilzer)
Comment 2 2010-04-07 09:47:59 PDT
(In reply to comment #1) > I meant WebCore/accessibility/efl and not WebCore/accessibility/platform/efl. Yes, it should be moved to WebCore/accessibility/efl/.
Gustavo Sverzut Barbieri
Comment 3 2010-04-07 14:27:39 PDT
Could someone move it then? The build system is still not integrated (#36761), then we could provide a new patch for build system with the correct path.
David Kilzer (:ddkilzer)
Comment 4 2010-04-08 08:29:43 PDT
(In reply to comment #3) > Could someone move it then? The build system is still not integrated (#36761), > then we could provide a new patch for build system with the correct path. Anyone can post a patch to move the file.
Antonio Gomes
Comment 5 2010-04-08 08:41:33 PDT
(In reply to comment #4) > (In reply to comment #3) > > Could someone move it then? The build system is still not integrated (#36761), > > then we could provide a new patch for build system with the correct path. > > Anyone can post a patch to move the file. as agreed on IRC w/ k-s (gustavo barbieri) i will do that now
Antonio Gomes
Comment 6 2010-04-08 08:46:24 PDT
Created attachment 52871 [details] (committed in r57282) patch v1
Laszlo Gombos
Comment 7 2010-04-08 08:52:14 PDT
Comment on attachment 52871 [details] (committed in r57282) patch v1 Looks good to me.
Antonio Gomes
Comment 8 2010-04-08 09:09:59 PDT
Comment on attachment 52871 [details] (committed in r57282) patch v1 thank you laszlo! Committing to http://svn.webkit.org/repository/webkit/trunk ... R WebCore/page/efl/AccessibilityObjectEfl.cpp => WebCore/accessibility/efl/AccessibilityObjectEfl.cpp M WebCore/ChangeLog Committed r57282
Note You need to log in before you can comment on or make changes to this bug.