Bug 36404

Summary:

[Gtk] Debug build fix when using a Gtk 2.20

Product:

WebKit

Reporter:

Holger Freyther <zecke>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

gustavo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Use non depcreated variants for the GtkWidget	none
Use the right version Gtk Version	none

Holger Freyther

Reported 2010-03-19 20:29:24 PDT

In debug mode we are compiling with GTK_NO_DEPRECATED and with Gtk+ 2.20 we are using deprecated symbols.

Attachments
Use non depcreated variants for the GtkWidget (4.69 KB, patch) 2010-03-19 20:42 PDT, Holger Freyther	no flags	Details Formatted Diff Diff
Use the right version Gtk Version (5.66 KB, patch) 2010-03-20 00:54 PDT, Holger Freyther	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Holger Freyther

Comment 1 2010-03-19 20:42:56 PDT

Created attachment 51213 [details] Use non depcreated variants for the GtkWidget GTK_WIDGET_REALIZED and GTK_WIDGET_NO_WINDOW are deprecated. For the GTK_WIDGET_NO_WINDOW case we need to use gtk_widget_get_has_window which actually returns _if_ we have a window, this means we need to negate that.

WebKit Review Bot

Comment 2 2010-03-19 20:51:36 PDT

Attachment 51213 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/977055

Holger Freyther

Comment 3 2010-03-20 00:54:44 PDT

Created attachment 51217 [details] Use the right version Gtk Version The new methods were added in 2.19... correct the GTK_CHECK_VERSION for that.

WebKit Review Bot

Comment 4 2010-03-20 00:56:54 PDT

Attachment 51217 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/plugins/gtk/gtk2xtbin.c:405: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/plugins/gtk/gtk2xtbin.c:465: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/plugins/gtk/gtk2xtbin.c:465: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gustavo Noronha (kov)

Comment 5 2010-03-22 08:19:25 PDT

Holger, I have an alternate proposal at https://bugs.webkit.org/show_bug.cgi?id=36398 What do you think?

Gustavo Noronha (kov)

Comment 6 2010-03-22 08:20:05 PDT

And yeah, it needs the same realized fix still, didn't get time to get to it yet, will fix the patch tonight.

Gustavo Noronha (kov)

Comment 7 2010-03-22 10:59:48 PDT

Since zecke told me he thinks my patch is good, I'll mark this as a duplicate of the bug I opened. *** This bug has been marked as a duplicate of bug 36398 ***

Eric Seidel (no email)

Comment 8 2010-03-25 00:26:15 PDT

Comment on attachment 51217 [details] Use the right version Gtk Version clearing r? on this closed bug.

Note You need to log in before you can comment on or make changes to this bug.