Bug 36401

Summary:

re-enable downstream overrides for chromium ports in new-run-webkit-tests

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Tools / Tests

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
sample downstream overrides file for test_expectations	none

Description Dirk Pranke 2010-03-19 18:18:42 PDT

undoing part of the change in bug 36396 / r56287 - we need to re-enable the downstream/chromium.org test_expectations file so that we can suppress errors without needing a webkit roll.

Comment 1 Dirk Pranke 2010-03-19 18:20:34 PDT

Created attachment 51209 [details]
Patch

Comment 2 Dirk Pranke 2010-03-19 18:22:30 PDT

Created attachment 51210 [details]
sample downstream overrides file for test_expectations

Dimitri - I suggest that when we zero-out the downstream test_expectations.txt file we replace it with something like the attached.

Comment 3 Ojan Vafai 2010-03-19 18:23:43 PDT

LGTM

Comment 4 Dimitri Glazkov (Google) 2010-03-20 10:15:54 PDT

Comment on attachment 51209 [details]
Patch

Let's do it!

Comment 5 Dimitri Glazkov (Google) 2010-03-20 10:21:30 PDT

Comment on attachment 51209 [details]
Patch

Clearing flags on attachment: 51209

Committed r56306: <http://trac.webkit.org/changeset/56306>

Comment 6 Dimitri Glazkov (Google) 2010-03-20 10:21:36 PDT

All reviewed patches have been landed.  Closing bug.