Bug 36389

Summary: [Qt] Remove support for Qt v4.4
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Laszlo Gombos <laszlo.gombos>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann, jedrzej.nowacki, tonikitoo
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Description Laszlo Gombos 2010-03-19 14:06:50 PDT
Support for 4.4 should be removed.
Comment 1 Laszlo Gombos 2010-03-19 14:23:50 PDT
Created attachment 51187 [details]
proposed patch
Comment 2 Jędrzej Nowacki 2010-03-22 07:25:11 PDT
I have found another places, for example

WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500
WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500
WebKit/qt/WebCoreSupport/EditorClientQt.cpp:#if QT_VERSION < 0x040500

I suggest to run 'git grep "QT_VERSION"' to find more :-)
Comment 3 Jędrzej Nowacki 2010-03-22 09:06:08 PDT
(In reply to comment #2)
> I have found another places, for example
> 
> WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500
> WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500
> WebKit/qt/WebCoreSupport/EditorClientQt.cpp:#if QT_VERSION < 0x040500
> 
> I suggest to run 'git grep "QT_VERSION"' to find more :-)

Sorry, I just skipped two of them. 

Looks good to me.
Comment 4 Simon Hausmann 2010-03-22 15:23:36 PDT
Assigning to Laszlo, so it doesn't show up in the list of untriaged bugs. This one is triaged :)
Comment 5 WebKit Commit Bot 2010-03-23 05:52:25 PDT
Comment on attachment 51187 [details]
proposed patch

Clearing flags on attachment: 51187

Committed r56386: <http://trac.webkit.org/changeset/56386>
Comment 6 WebKit Commit Bot 2010-03-23 05:52:29 PDT
All reviewed patches have been landed.  Closing bug.