Summary: | [Qt] Remove support for Qt v4.4 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> | ||||
Component: | Platform | Assignee: | Laszlo Gombos <laszlo.gombos> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, hausmann, jedrzej.nowacki, tonikitoo | ||||
Priority: | P3 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Laszlo Gombos
2010-03-19 14:06:50 PDT
Created attachment 51187 [details]
proposed patch
I have found another places, for example WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500 WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500 WebKit/qt/WebCoreSupport/EditorClientQt.cpp:#if QT_VERSION < 0x040500 I suggest to run 'git grep "QT_VERSION"' to find more :-) (In reply to comment #2) > I have found another places, for example > > WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500 > WebCore/platform/qt/KURLQt.cpp:#if QT_VERSION < 0x040500 > WebKit/qt/WebCoreSupport/EditorClientQt.cpp:#if QT_VERSION < 0x040500 > > I suggest to run 'git grep "QT_VERSION"' to find more :-) Sorry, I just skipped two of them. Looks good to me. Assigning to Laszlo, so it doesn't show up in the list of untriaged bugs. This one is triaged :) Comment on attachment 51187 [details] proposed patch Clearing flags on attachment: 51187 Committed r56386: <http://trac.webkit.org/changeset/56386> All reviewed patches have been landed. Closing bug. |