Bug 36370

Summary:

[Qt] Maemo5 theme - form controls style

Product:

WebKit

Reporter:

Luiz Agostini <luiz>

Component:

Platform

Assignee:

Luiz Agostini <luiz>

Status:

CLOSED FIXED

Severity:

Normal

CC:

commit-queue, hausmann, kenneth

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Bug Depends on:

Bug Blocks:

36372

Attachments:

Description	Flags
screenshot - MicroB 1	none
screenshot - MicroB 2	none
screenshot - WebKit 1	none
screenshot - WebKit 2	none
screenshot - WebKit 3	none
patch 1	none
patch 2	none
patch 3	none

Description Luiz Agostini 2010-03-19 08:10:43 PDT

<input>, <textarea>, <select>, etc must have its look customized in maemo5.

Comment 1 Tor Arne Vestbø 2010-03-22 06:37:02 PDT

Bugs relating to the Qt port of WebKit should have the Qt keyword. See http://trac.webkit.org/wiki/QtWebKitBugs

Comment 2 Simon Hausmann 2010-03-28 14:01:03 PDT

(In reply to comment #0)
> <input>, <textarea>, <select>, etc must have its look customized in maemo5.

What customization is this?

Comment 3 Luiz Agostini 2010-03-31 07:48:37 PDT

Created attachment 52162 [details]
screenshot - MicroB 1

Comment 4 Luiz Agostini 2010-03-31 07:49:17 PDT

Created attachment 52163 [details]
screenshot - MicroB 2

Comment 5 Luiz Agostini 2010-03-31 07:50:18 PDT

Created attachment 52164 [details]
screenshot - WebKit 1

Comment 6 Luiz Agostini 2010-03-31 07:50:45 PDT

Created attachment 52165 [details]
screenshot - WebKit 2

Comment 7 Luiz Agostini 2010-03-31 08:05:56 PDT

Created attachment 52169 [details]
screenshot - WebKit 3

Comment 8 Luiz Agostini 2010-03-31 08:12:11 PDT

Created attachment 52170 [details]
patch 1

Comment 9 Kenneth Rohde Christiansen 2010-03-31 08:14:55 PDT

Comment on attachment 52170 [details]
patch 1


> +
> +static inline void drawRectangularControlBackgorund(QPainter* painter, const QPen& pen,
> +                                                    const QRect& rect, const QBrush& brush)

Backgorund? :-) wrong spelling

Comment 10 Luiz Agostini 2010-03-31 08:31:22 PDT

Created attachment 52174 [details]
patch 2

Comment 11 Luiz Agostini 2010-03-31 10:28:34 PDT

Created attachment 52184 [details]
patch 3

Comment 12 WebKit Commit Bot 2010-03-31 13:18:16 PDT

Comment on attachment 52184 [details]
patch 3

Clearing flags on attachment: 52184

Committed r56860: <http://trac.webkit.org/changeset/56860>

Comment 13 WebKit Commit Bot 2010-03-31 13:18:22 PDT

All reviewed patches have been landed.  Closing bug.

Comment 14 Simon Hausmann 2010-04-06 03:02:07 PDT

Revision r56860 cherry-picked into qtwebkit-2.0 with commit 88cd40ec9ccf6f0823e7101f5bee5cf776e7c012