CLOSED FIXED Bug 36370
[Qt] Maemo5 theme - form controls style 
https://bugs.webkit.org/show_bug.cgi?id=36370
Summary [Qt] Maemo5 theme - form controls style
Luiz Agostini
Reported 2010-03-19 08:10:43 PDT
<input>, <textarea>, <select>, etc must have its look customized in maemo5.
Attachments
screenshot - MicroB 1 (55.16 KB, image/png)
2010-03-31 07:48 PDT, Luiz Agostini 		no flags
Details
screenshot - MicroB 2 (52.86 KB, image/png)
2010-03-31 07:49 PDT, Luiz Agostini 		no flags
Details
screenshot - WebKit 1 (47.44 KB, image/png)
2010-03-31 07:50 PDT, Luiz Agostini 		no flags
Details
screenshot - WebKit 2 (47.14 KB, image/png)
2010-03-31 07:50 PDT, Luiz Agostini 		no flags
Details
screenshot - WebKit 3 (49.76 KB, image/png)
2010-03-31 08:05 PDT, Luiz Agostini 		no flags
Details
patch 1 (19.33 KB, patch)
2010-03-31 08:12 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch 2 (19.28 KB, patch)
2010-03-31 08:31 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch 3 (19.28 KB, patch)
2010-03-31 10:28 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1 2010-03-22 06:37:02 PDT
Bugs relating to the Qt port of WebKit should have the Qt keyword. See http://trac.webkit.org/wiki/QtWebKitBugs
Simon Hausmann
Comment 2 2010-03-28 14:01:03 PDT
(In reply to comment #0) > <input>, <textarea>, <select>, etc must have its look customized in maemo5. What customization is this?
Luiz Agostini
Comment 3 2010-03-31 07:48:37 PDT
Created attachment 52162 [details] screenshot - MicroB 1
Luiz Agostini
Comment 4 2010-03-31 07:49:17 PDT
Created attachment 52163 [details] screenshot - MicroB 2
Luiz Agostini
Comment 5 2010-03-31 07:50:18 PDT
Created attachment 52164 [details] screenshot - WebKit 1
Luiz Agostini
Comment 6 2010-03-31 07:50:45 PDT
Created attachment 52165 [details] screenshot - WebKit 2
Luiz Agostini
Comment 7 2010-03-31 08:05:56 PDT
Created attachment 52169 [details] screenshot - WebKit 3
Luiz Agostini
Comment 8 2010-03-31 08:12:11 PDT
Created attachment 52170 [details] patch 1
Kenneth Rohde Christiansen
Comment 9 2010-03-31 08:14:55 PDT
Comment on attachment 52170 [details] patch 1 > + > +static inline void drawRectangularControlBackgorund(QPainter* painter, const QPen& pen, > + const QRect& rect, const QBrush& brush) Backgorund? :-) wrong spelling
Luiz Agostini
Comment 10 2010-03-31 08:31:22 PDT
Created attachment 52174 [details] patch 2
Luiz Agostini
Comment 11 2010-03-31 10:28:34 PDT
Created attachment 52184 [details] patch 3
WebKit Commit Bot
Comment 12 2010-03-31 13:18:16 PDT
Comment on attachment 52184 [details] patch 3 Clearing flags on attachment: 52184 Committed r56860: <http://trac.webkit.org/changeset/56860>
WebKit Commit Bot
Comment 13 2010-03-31 13:18:22 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 14 2010-04-06 03:02:07 PDT
Revision r56860 cherry-picked into qtwebkit-2.0 with commit 88cd40ec9ccf6f0823e7101f5bee5cf776e7c012
Note You need to log in before you can comment on or make changes to this bug.