Bug 36348

Summary: [Qt] Disable TILED_BACKING_STORE if Qt version is earlier than Qt4.6
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebCore Misc.Assignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann, koivisto, tonikitoo
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Laszlo Gombos
Reported 2010-03-19 00:16:59 PDT
It seems that the QtWebKit tiled backing store needs the QGraphicsItem::scale function (seeQGraphicsWebViewPrivate::updateTiledBackingStoreScale). I propose to turn off TILED_BACKING_STORE if Qt version is earlier than Qt4.6 (instead of making it work on Qt 4.5 or earlier).
Attachments
proposed patch (1.30 KB, patch)
2010-03-19 00:21 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-03-19 00:21:11 PDT
Created attachment 51130 [details] proposed patch
Simon Hausmann
Comment 2 2010-03-19 00:35:41 PDT
QGraphicsItem::scale is present in Qt 4.5, but it's not a Q_PROPERTY in QGraphicsObject.
Antonio Gomes
Comment 3 2010-03-19 08:49:56 PDT
i confess I do not know what is the current minimum version of Qt that QtWebKit has to support. one mentioned it is current release (4.6) and the next (4.7). If so, should we care much about 4.5? just out of curiosity.
WebKit Commit Bot
Comment 4 2010-03-19 09:41:55 PDT
Comment on attachment 51130 [details] proposed patch Clearing flags on attachment: 51130 Committed r56243: <http://trac.webkit.org/changeset/56243>
WebKit Commit Bot
Comment 5 2010-03-19 09:42:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.