Bug 36324

Summary: new-run-webkit-tests needs to be able to find Chromium baselines upstream as well as downstream
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, victorw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch dglazkov: review+

Dirk Pranke
Reported 2010-03-18 14:31:27 PDT
We are getting ready to land all of the Chromium LayoutTest baselines upstream, and so we need to modify the new-run-webkit-tests infrastructure to look for them upstream as well as downstream (downstream expectations trump upstream ones).
Attachments
Patch (3.91 KB, patch)
2010-03-18 14:34 PDT, Dirk Pranke 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-03-18 14:34:01 PDT
Created attachment 51094 [details] Patch
Ojan Vafai
Comment 2 2010-03-18 14:46:55 PDT
Comment on attachment 51094 [details] Patch Please put in FIXMEs to remove the chromium_baseline_path calls once the baselines are all moved upstream. Otherwise, lgtm.
Dirk Pranke
Comment 3 2010-03-18 15:22:39 PDT
(In reply to comment #2) > (From update of attachment 51094 [details]) > Please put in FIXMEs to remove the chromium_baseline_path calls once the > baselines are all moved upstream. Otherwise, lgtm. I'm not actually 100% sure that we won't want to keep the downstream paths around in case we need to (temporarily) check in downstream baselines. But, it's probably safer for the gardeners if we don't make this possible out of the gate, so I will do as you say. We can always add this back in if we need it.
Dimitri Glazkov (Google)
Comment 4 2010-03-18 15:38:27 PDT
Comment on attachment 51094 [details] Patch rs=me.
Dirk Pranke
Comment 5 2010-03-18 15:45:36 PDT
Committed r56199: <http://trac.webkit.org/changeset/56199>
Note You need to log in before you can comment on or make changes to this bug.