Summary: | new-run-webkit-tests needs to be able to find Chromium baselines upstream as well as downstream | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, victorw | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Dirk Pranke
2010-03-18 14:31:27 PDT
Created attachment 51094 [details]
Patch
Comment on attachment 51094 [details]
Patch
Please put in FIXMEs to remove the chromium_baseline_path calls once the baselines are all moved upstream. Otherwise, lgtm.
(In reply to comment #2) > (From update of attachment 51094 [details]) > Please put in FIXMEs to remove the chromium_baseline_path calls once the > baselines are all moved upstream. Otherwise, lgtm. I'm not actually 100% sure that we won't want to keep the downstream paths around in case we need to (temporarily) check in downstream baselines. But, it's probably safer for the gardeners if we don't make this possible out of the gate, so I will do as you say. We can always add this back in if we need it. Comment on attachment 51094 [details]
Patch
rs=me.
Committed r56199: <http://trac.webkit.org/changeset/56199> |