Bug 36272

Summary: CSS3 :nth-child selector with implied step test fails
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
URL: http://samples.msdn.microsoft.com/ietestcenter/css3/selectors/impliedValue.htm
Attachments:
Description Flags
Testcase
none
Patch simon.fraser: review+

Description Simon Fraser (smfr) 2010-03-17 20:16:30 PDT 
Created attachment 50998 [details]
Testcase

The test here fails:
http://samples.msdn.microsoft.com/ietestcenter/css3/selectors/impliedValue.htm
Comment 1 Dave Hyatt 2010-03-23 13:45:04 PDT 
Created attachment 51451 [details]
Patch
Comment 2 Simon Fraser (smfr) 2010-03-23 13:48:01 PDT 
Comment on attachment 51451 [details]
Patch

Where is LayoutTests/ChangeLog?
r=me.
Comment 3 Darin Adler 2010-03-23 13:49:36 PDT 
Comment on attachment 51451 [details]
Patch

> -        $$->setArgument(String::number($4));
> +        $$->setArgument(String::number($4*$5));

Should be $4 * $5 with spaces around the multiplication operator.

I'd like to see test cases covering the edge cases, for example the maximum negative number.

r=me
Comment 4 Dave Hyatt 2010-03-23 13:53:07 PDT 
Fixed in r56414.