Bug 36255

Summary:

Remove Geolocation.lastPosition, no longer in the spec.

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebKit Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kenneth, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	kenneth: review+

Darin Adler

Reported 2010-03-17 17:47:36 PDT

Remove Geolocation.lastPosition, no longer in the spec.

Attachments
Patch (4.75 KB, patch) 2010-03-17 17:50 PDT, Darin Adler	kenneth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2010-03-17 17:50:37 PDT

Created attachment 50983 [details] Patch

Kenneth Rohde Christiansen

Comment 2 2010-03-17 17:57:43 PDT

Comment on attachment 50983 [details] Patch LGTM.

Darin Adler

Comment 3 2010-03-18 13:33:55 PDT

Not sure why the EWS is not running on this patch. Maybe it only runs on review? patches?

Darin Adler

Comment 4 2010-03-18 13:42:33 PDT

http://trac.webkit.org/changeset/56188

Steve Block

Comment 5 2010-03-18 16:37:32 PDT

The suspend() and resume() methods are used by Android (and soon Chromium). Is it possible to add them back? See Bug 36255 for how they're used.

Darin Adler

Comment 6 2010-03-18 17:09:22 PDT

GeolocationServiceBridgeChromium.cpp says: getWebViewClient()->getGeolocationService()->suspend(m_bridgeId) Bug 36255 is this bug. If you do need those functions on certain platforms, then I suppose it's OK to bring them back. It's not good to have requirements that can't be seen by someone just be looking at the WebKit source tree. Android is not in a good state for maintenance until the WebKit code is checked in to the open source project.

Steve Block

Comment 7 2010-03-18 18:38:22 PDT

> Bug 36255 is this bug. Sorry, I meant Bug 34082 > It's not good to have requirements that can't be seen by > someone just be looking at the WebKit source tree. Android is not in a good > state for maintenance until the WebKit code is checked in to the open source > project. Agreed. We're working hard right now to upstream all of Android's WebKit code.

Steve Block

Comment 8 2010-04-21 13:16:05 PDT

> If you do need those functions on certain platforms, then I suppose it's OK to > bring them back. OK, I've opened Bug 37942 to track this.

Note You need to log in before you can comment on or make changes to this bug.