Bug 36255

Summary: Remove Geolocation.lastPosition, no longer in the spec.
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch kenneth: review+

Description Darin Adler 2010-03-17 17:47:36 PDT 
Remove Geolocation.lastPosition, no longer in the spec.
Comment 1 Darin Adler 2010-03-17 17:50:37 PDT 
Created attachment 50983 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2010-03-17 17:57:43 PDT 
Comment on attachment 50983 [details]
Patch

LGTM.
Comment 3 Darin Adler 2010-03-18 13:33:55 PDT 
Not sure why the EWS is not running on this patch. Maybe it only runs on review? patches?
Comment 4 Darin Adler 2010-03-18 13:42:33 PDT 
http://trac.webkit.org/changeset/56188
Comment 5 Steve Block 2010-03-18 16:37:32 PDT 
The suspend() and resume() methods are used by Android (and soon Chromium). Is it possible to add them back?

See Bug 36255 for how they're used.
Comment 6 Darin Adler 2010-03-18 17:09:22 PDT 
GeolocationServiceBridgeChromium.cpp says:

    getWebViewClient()->getGeolocationService()->suspend(m_bridgeId)

Bug 36255 is this bug.

If you do need those functions on certain platforms, then I suppose it's OK to bring them back. It's not good to have requirements that can't be seen by someone just be looking at the WebKit source tree. Android is not in a good state for maintenance until the WebKit code is checked in to the open source project.
Comment 7 Steve Block 2010-03-18 18:38:22 PDT 
> Bug 36255 is this bug.
Sorry, I meant Bug 34082

> It's not good to have requirements that can't be seen by
> someone just be looking at the WebKit source tree. Android is not in a good
> state for maintenance until the WebKit code is checked in to the open source
> project.
Agreed. We're working hard right now to upstream all of Android's WebKit code.
Comment 8 Steve Block 2010-04-21 13:16:05 PDT 
> If you do need those functions on certain platforms, then I suppose it's OK to
> bring them back.
OK, I've opened Bug 37942 to track this.