Bug 36254

Summary:

Add more infrastructure for sheriff-bot, including making what-broke more awesome

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+

Eric Seidel (no email)

Reported 2010-03-17 17:46:01 PDT

Add more infrastructure for sheriff-bot, including making what-broke more awesome

Attachments
Patch (37.46 KB, patch) 2010-03-17 17:48 PDT, Eric Seidel (no email)	abarth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-03-17 17:48:05 PDT

Created attachment 50981 [details] Patch

Eric Seidel (no email)

Comment 2 2010-03-17 17:51:13 PDT

CCing dbates, as I think he is the culprit behind the SCM.commit_with_message breakage of the scm unittests. :)

Adam Barth

Comment 3 2010-03-17 18:04:40 PDT

Comment on attachment 50981 [details] Patch This is like 27 different patch, but ok. Also, all the code you're adding to what-broke needs to be factored out into separate concepts so it can be re-used by other parts of the system. Thanks for fixing all the SCM unit tests.

Eric Seidel (no email)

Comment 4 2010-03-17 18:09:58 PDT

Committed r56137: <http://trac.webkit.org/changeset/56137>

Note You need to log in before you can comment on or make changes to this bug.